We were fetching all of our devices everytime a new message was received.
This was only used for when the message was a public chat message, so i moved it into the relevant if statement.
In the future if we increase the device link limit, we'll need to fetch all our devices on application launch or something.
passing number zero to environmental variables UNSETS the variable, pass "0" instead.
this commit makes it "work" but is probably not the right fix, that comes later. (tm)
This is the reason that seeds across desktop and mobile devices would never restore to the same keypair. This function was there from the initial messenger days and with further discussion with Maxim, we deemed calling this function an unnecessary step for generating a keypair. There are no security implications for this change as we generate keypairs the exact same way as Signal does.
The biggest downside to this change however is that if you try to restore a desktop device with a seed from before this change, that seed will generate a completely different key pair and thus a different session ID.
This will only affect users who plan to restore any device from the seed of a desktop device before this change.
First it will ask the user about downloading the new update.
Then it will download the update and ask the user to restart the application.
This was done so that if the company was forced to put out comprimised binaries, all our users won't be automatically updated to them.
Mikunj
Konstantin Ullrich
Mikunj Varsani
Jeff Becker
Vince
Ryan Tharp
Audric Ackermann