From cc5327dbc96a1c1241cee06d3ac715abb13e1de5 Mon Sep 17 00:00:00 2001 From: lilia Date: Fri, 17 Oct 2014 20:57:39 -0700 Subject: [PATCH] Fix group loop All the group messages were being sent to the last recipient in the list, due to the persistence of `var number` in later loops and async calls. An easy mistake to make, when you use for instead of each. --- js/sendmessage.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/js/sendmessage.js b/js/sendmessage.js index 73daf9135..fb2354ff1 100644 --- a/js/sendmessage.js +++ b/js/sendmessage.js @@ -170,8 +170,7 @@ window.textsecure.messaging = function() { }); } - for (var i = 0; i < numbers.length; i++) { - var number = numbers[i]; + _.each(numbers, function(number) { var devicesForNumber = textsecure.storage.devices.getDeviceObjectsForNumber(number); var promises = []; @@ -191,7 +190,7 @@ window.textsecure.messaging = function() { } else doSendMessage(number, devicesForNumber, true); }); - } + }); } makeAttachmentPointer = function(attachment) {