handle duplicate convos when removing prefix.

we drop the convo with the less messages to keep the unique constraint on
conversation IDs

app/sql.js

@@ -3061,6 +3061,15 @@ async function removeKnownAttachments(allAttachments) {
   return Object.keys(lookup);
 }
 
+async function getMessagesCountByConversation(instance, conversationId) {
+  const row = await instance.get(
+    'SELECT count(*) from messages WHERE conversationId = $conversationId;',
+    { $conversationId: conversationId }
+  );
+
+  return row ? row['count(*)'] : 0;
+}
+
 async function removePrefixFromGroupConversations(instance) {
   const rows = await instance.all(
     `SELECT json FROM conversations WHERE
@@ -3070,13 +3079,61 @@ async function removePrefixFromGroupConversations(instance) {
 
   const objs = map(rows, row => jsonToObject(row.json));
 
+  const conversationIdRows = await instance.all(
+    `SELECT id FROM ${CONVERSATIONS_TABLE} ORDER BY id ASC;`
+  );
+  const allOldConversationIds = map(conversationIdRows, row => row.id);
+
   await Promise.all(
     objs.map(async o => {
       const oldId = o.id;
       const newId = oldId.replace('__textsecure_group__!', '');
-
       console.log(`migrating conversation, ${oldId} to ${newId}`);
 
+      if (allOldConversationIds.includes(newId)) {
+        console.log(
+          'Found a duplicate conversation after prefix removing. We need to take care of it'
+        );
+        // We have another conversation with the same future name.
+        // We decided to keep only the conversation with the higher number of messages
+        const countMessagesOld = await getMessagesCountByConversation(
+          instance,
+          oldId,
+          { limit: Number.MAX_VALUE }
+        );
+        const countMessagesNew = await getMessagesCountByConversation(
+          instance,
+          newId,
+          { limit: Number.MAX_VALUE }
+        );
+
+        console.log(
+          `countMessagesOld: ${countMessagesOld}, countMessagesNew: ${countMessagesNew}`
+        );
+
+        if (countMessagesOld > countMessagesNew) {
+          console.log(
+            'Removing the conversation without the prefix as there are less messages in it'
+          );
+          await instance.run(
+            `DELETE FROM ${CONVERSATIONS_TABLE} WHERE id = $id;`,
+            {
+              $id: newId,
+            }
+          );
+        } else {
+          console.log(
+            'Removing the conversation with the prefix as there are less messages in it'
+          );
+          await instance.run(
+            `DELETE FROM ${CONVERSATIONS_TABLE} WHERE id = $id;`,
+            {
+              $id: oldId,
+            }
+          );
+        }
+      }
+
       const morphedObject = {
         ...o,
         id: newId,

js/views/conversation_view.js

@@ -732,7 +732,7 @@
       //   this.$('.send-message').val().length > 0 ||
       //   this.fileInput.hasFiles()
       // ) {
-        this.$('.capture-audio').hide();
+      this.$('.capture-audio').hide();
       // } else {
       //   this.$('.capture-audio').show();
       // }