From c31535edb41eb18d890721d1c503027bbdc73d6b Mon Sep 17 00:00:00 2001
From: Beaudan Brown <beau@loki.network>
Date: Fri, 8 Nov 2019 11:00:32 +1100
Subject: [PATCH] Rename blockSync, only send contacts and profile if sending a
 GRANT request, do *not* always be friends with secondary devices because we
 still need to complete a friend request exchange

---
 js/background.js                  |  2 +-
 js/models/conversations.js        |  4 +--
 libloki/api.js                    | 43 ++++++++++++++-----------------
 libtextsecure/message_receiver.js |  9 ++++---
 4 files changed, 28 insertions(+), 30 deletions(-)

diff --git a/js/background.js b/js/background.js
index 617aade94..5aaec5be3 100644
--- a/js/background.js
+++ b/js/background.js
@@ -1244,7 +1244,7 @@
         libloki.api.sendBackgroundMessage(conversation.id);
       } else {
         // Accept any pending friend requests if there are any
-        conversation.onAcceptFriendRequest({ fromContactSync: true });
+        conversation.onAcceptFriendRequest({ blockSync: true });
       }
 
       if (details.profileKey) {
diff --git a/js/models/conversations.js b/js/models/conversations.js
index 1f562ab23..40d459abb 100644
--- a/js/models/conversations.js
+++ b/js/models/conversations.js
@@ -775,7 +775,7 @@
       }
     },
     async setFriendRequestStatus(newStatus, options = {}) {
-      const { fromContactSync } = options;
+      const { blockSync } = options;
       // Ensure that the new status is a valid FriendStatusEnum value
       if (!(newStatus in Object.values(FriendRequestStatusEnum))) {
         return;
@@ -792,7 +792,7 @@
           Conversation: Whisper.Conversation,
         });
         await this.updateTextInputState();
-        if (!fromContactSync && newStatus === FriendRequestStatusEnum.friends) {
+        if (!blockSync && newStatus === FriendRequestStatusEnum.friends) {
           // Sync contact
           this.wrapSend(textsecure.messaging.sendContactSyncMessage(this));
         }
diff --git a/libloki/api.js b/libloki/api.js
index 5d5949d0b..e606c554b 100644
--- a/libloki/api.js
+++ b/libloki/api.js
@@ -165,33 +165,28 @@
       ourNumber,
       'private'
     );
-    const secondaryConversation = await ConversationController.getOrCreateAndWait(
-      recipientPubKey,
-      'private'
-    );
-    // Always be friends with secondary devices
-    secondaryConversation.setFriendRequestStatus(
-      window.friends.friendRequestStatusEnum.friends
-    );
-    // Send profile name to secondary device
-    const lokiProfile = ourConversation.getLokiProfile();
-    const profile = new textsecure.protobuf.DataMessage.LokiProfile(
-      lokiProfile
-    );
-    const dataMessage = new textsecure.protobuf.DataMessage({
-      profile,
-    });
-    // Attach contact list
-    const conversations = await window.Signal.Data.getConversationsWithFriendStatus(
-      window.friends.friendRequestStatusEnum.friends,
-      { ConversationCollection: Whisper.ConversationCollection }
-    );
-    const syncMessage = await createContactSyncProtoMessage(conversations);
     const content = new textsecure.protobuf.Content({
       pairingAuthorisation,
-      dataMessage,
-      syncMessage,
     });
+    const isGrant = authorisation.primaryDevicePubKey === ourNumber;
+    if (isGrant) {
+      // Send profile name to secondary device
+      const lokiProfile = ourConversation.getLokiProfile();
+      const profile = new textsecure.protobuf.DataMessage.LokiProfile(
+        lokiProfile
+      );
+      const dataMessage = new textsecure.protobuf.DataMessage({
+        profile,
+      });
+      // Attach contact list
+      const conversations = await window.Signal.Data.getConversationsWithFriendStatus(
+        window.friends.friendRequestStatusEnum.friends,
+        { ConversationCollection: Whisper.ConversationCollection }
+      );
+      const syncMessage = await createContactSyncProtoMessage(conversations);
+      content.syncMessage = syncMessage;
+      content.dataMessage = dataMessage;
+    }
     // Send
     const options = { messageType: 'pairing-request' };
     const p = new Promise((resolve, reject) => {
diff --git a/libtextsecure/message_receiver.js b/libtextsecure/message_receiver.js
index da2d7ff17..e62c8494e 100644
--- a/libtextsecure/message_receiver.js
+++ b/libtextsecure/message_receiver.js
@@ -1232,8 +1232,6 @@ MessageReceiver.prototype.extend({
       return false;
     }
     await libloki.storage.savePairingAuthorisation(authorisation);
-    // sending a message back = accepting friend request
-    window.libloki.api.sendBackgroundMessage(pubKey);
 
     return true;
   },
@@ -1293,7 +1291,12 @@ MessageReceiver.prototype.extend({
               deviceMapping
             );
             if (autoAccepted) {
-              await conversation.onFriendRequestAccepted();
+              // sending a message back = accepting friend request
+              // Directly setting friend request status to skip the pending state
+              await conversation.setFriendRequestStatus(
+                window.friends.friendRequestStatusEnum.friends
+              );
+              window.libloki.api.sendBackgroundMessage(envelope.source);
               return this.removeFromCache(envelope);
             }
           }