From bc86dd6c1f14812595a94f3391f7b0af0e002ebb Mon Sep 17 00:00:00 2001
From: yougotwill <willmgrant@gmail.com>
Date: Thu, 15 Aug 2024 10:09:56 +1000
Subject: [PATCH] feat: generic attachments for messages components

---
 .../message-content/MessageAttachment.tsx     | 59 +++------------
 .../MessageGenericAttachment.tsx              | 73 +++++++++++++++++++
 2 files changed, 82 insertions(+), 50 deletions(-)
 create mode 100644 ts/components/conversation/message/message-content/MessageGenericAttachment.tsx

diff --git a/ts/components/conversation/message/message-content/MessageAttachment.tsx b/ts/components/conversation/message/message-content/MessageAttachment.tsx
index a151da754..aa680f4b8 100644
--- a/ts/components/conversation/message/message-content/MessageAttachment.tsx
+++ b/ts/components/conversation/message/message-content/MessageAttachment.tsx
@@ -1,4 +1,3 @@
-import classNames from 'classnames';
 import { clone } from 'lodash';
 import { useCallback } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
@@ -16,8 +15,6 @@ import {
 import {
   AttachmentType,
   AttachmentTypeWithPath,
-  canDisplayImagePreview,
-  getExtensionForDisplay,
   hasImage,
   hasVideoScreenshot,
   isAudio,
@@ -26,12 +23,12 @@ import {
 } from '../../../../types/Attachment';
 import { saveAttachmentToDisk } from '../../../../util/attachmentsUtil';
 import { MediaItemType } from '../../../lightbox/LightboxGallery';
-import { Spinner } from '../../../loading';
 import { AudioPlayerWithEncryptedFile } from '../../H5AudioPlayer';
 import { ImageGrid } from '../../ImageGrid';
 import { ClickToTrustSender } from './ClickToTrustSender';
 import { MessageHighlighter } from './MessageHighlighter';
 import { useIsDetailMessageView } from '../../../../contexts/isDetailViewContext';
+import { MessageGenericAttachment } from './MessageGenericAttachment';
 
 export type MessageAttachmentSelectorProps = Pick<
   MessageRenderingProps,
@@ -62,10 +59,6 @@ const StyledImageGridContainer = styled.div<{
   justify-content: ${props => (props.messageDirection === 'incoming' ? 'flex-start' : 'flex-end')};
 `;
 
-const StyledGenericAttachmentContainer = styled(MessageHighlighter)<{ selected: boolean }>`
-  ${props => props.selected && 'box-shadow: var(--drop-shadow);'}
-`;
-
 export const MessageAttachment = (props: Props) => {
   const { messageId, imageBroken, handleImageError, highlight = false } = props;
   const isDetailView = useIsDetailMessageView();
@@ -130,17 +123,14 @@ export const MessageAttachment = (props: Props) => {
   }
 
   const firstAttachment = attachments[0];
-  const displayImage = canDisplayImagePreview(attachments);
 
   if (!isTrustedForAttachmentDownload) {
     return <ClickToTrustSender messageId={messageId} />;
   }
 
   if (
-    displayImage &&
-    !imageBroken &&
-    ((isImage(attachments) && hasImage(attachments)) ||
-      (isVideo(attachments) && hasVideoScreenshot(attachments)))
+    (isImage(attachments) && hasImage(attachments)) ||
+    (isVideo(attachments) && hasVideoScreenshot(attachments))
   ) {
     // we use the carousel in the detail view
     if (isDetailView) {
@@ -152,6 +142,8 @@ export const MessageAttachment = (props: Props) => {
           <ImageGrid
             messageId={messageId}
             attachments={attachments}
+            imageBroken={imageBroken}
+            highlight={highlight}
             onError={handleImageError}
             onClickAttachment={onClickOnImageGrid}
           />
@@ -181,48 +173,15 @@ export const MessageAttachment = (props: Props) => {
       </MessageHighlighter>
     );
   }
-  const { pending, fileName, fileSize, contentType } = firstAttachment;
-  const extension = getExtensionForDisplay({ contentType, fileName });
 
   return (
-    <StyledGenericAttachmentContainer
+    <MessageGenericAttachment
+      attachment={firstAttachment}
+      direction={direction}
       highlight={highlight}
       selected={selected}
-      className={'module-message__generic-attachment'}
       onClick={onClickOnGenericAttachment}
-    >
-      {pending ? (
-        <div className="module-message__generic-attachment__spinner-container">
-          <Spinner size="small" />
-        </div>
-      ) : (
-        <div className="module-message__generic-attachment__icon-container">
-          <div role="button" className="module-message__generic-attachment__icon">
-            {extension ? (
-              <div className="module-message__generic-attachment__icon__extension">{extension}</div>
-            ) : null}
-          </div>
-        </div>
-      )}
-      <div className="module-message__generic-attachment__text">
-        <div
-          className={classNames(
-            'module-message__generic-attachment__file-name',
-            `module-message__generic-attachment__file-name--${direction}`
-          )}
-        >
-          {fileName}
-        </div>
-        <div
-          className={classNames(
-            'module-message__generic-attachment__file-size',
-            `module-message__generic-attachment__file-size--${direction}`
-          )}
-        >
-          {fileSize}
-        </div>
-      </div>
-    </StyledGenericAttachmentContainer>
+    />
   );
 };
 
diff --git a/ts/components/conversation/message/message-content/MessageGenericAttachment.tsx b/ts/components/conversation/message/message-content/MessageGenericAttachment.tsx
new file mode 100644
index 000000000..a567233e0
--- /dev/null
+++ b/ts/components/conversation/message/message-content/MessageGenericAttachment.tsx
@@ -0,0 +1,73 @@
+import classNames from 'classnames';
+import styled from 'styled-components';
+import { PropsForAttachment } from '../../../../state/ducks/conversations';
+import { AttachmentTypeWithPath, getExtensionForDisplay } from '../../../../types/Attachment';
+import { Spinner } from '../../../loading';
+import { MessageModelType } from '../../../../models/messageType';
+import { MessageHighlighter } from './MessageHighlighter';
+
+const StyledGenericAttachmentContainer = styled(MessageHighlighter)<{
+  highlight: boolean;
+  selected: boolean;
+}>`
+  ${props => props.selected && 'box-shadow: var(--drop-shadow);'}
+`;
+
+export function MessageGenericAttachment({
+  attachment,
+  direction,
+  highlight,
+  selected,
+  onClick,
+}: {
+  attachment: PropsForAttachment | AttachmentTypeWithPath;
+  highlight: boolean;
+  selected: boolean;
+  direction?: MessageModelType;
+  onClick?: (e: any) => void;
+}) {
+  // TODO add higher level pending or loading states
+  const { pending, fileName, fileSize, contentType } = attachment;
+  const extension = getExtensionForDisplay({ contentType, fileName });
+
+  return (
+    <StyledGenericAttachmentContainer
+      highlight={highlight}
+      selected={selected}
+      className={'module-message__generic-attachment'}
+      onClick={onClick}
+    >
+      {pending ? (
+        <div className="module-message__generic-attachment__spinner-container">
+          <Spinner size="small" />
+        </div>
+      ) : (
+        <div className="module-message__generic-attachment__icon-container">
+          <div role="button" className="module-message__generic-attachment__icon">
+            {extension ? (
+              <div className="module-message__generic-attachment__icon__extension">{extension}</div>
+            ) : null}
+          </div>
+        </div>
+      )}
+      <div className="module-message__generic-attachment__text">
+        <div
+          className={classNames(
+            'module-message__generic-attachment__file-name',
+            `module-message__generic-attachment__file-name--${direction}`
+          )}
+        >
+          {fileName}
+        </div>
+        <div
+          className={classNames(
+            'module-message__generic-attachment__file-size',
+            `module-message__generic-attachment__file-size--${direction}`
+          )}
+        >
+          {fileSize}
+        </div>
+      </div>
+    </StyledGenericAttachmentContainer>
+  );
+}