From b97a68c7f6f9b712e53bcf058f8dff356c80da6e Mon Sep 17 00:00:00 2001
From: Mikunj <mikunj@live.com.au>
Date: Thu, 26 Mar 2020 15:56:15 +1100
Subject: [PATCH] Guard against empty NODE_APP_INSTANCE

---
 app/user_config.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/user_config.js b/app/user_config.js
index 63d0b3dd5..20b5b70c3 100644
--- a/app/user_config.js
+++ b/app/user_config.js
@@ -8,7 +8,8 @@ const config = require('./config');
 
 let storageProfile;
 const { NODE_ENV: environment, NODE_APP_INSTANCE:instance } = process.env;
-const isProduction = environment === 'production' && !instance;
+const isValidInstance = instance && instance.length > 0;
+const isProduction = environment === 'production' && !isValidInstance;
 
 // Use seperate data directories for each different environment and app instances
 // We should prioritise config values first
@@ -16,7 +17,7 @@ if (config.has(storageProfile)) {
   storageProfile = config.get('storageProfile');
 } else if (!isProduction) {
   storageProfile = environment;
-  if (instance) {
+  if (isValidInstance) {
     storageProfile = storageProfile.concat(`-${instance}`)
   }
 }