From aef6d9e8a7c6f20d301d29ceddc04dcdca62863e Mon Sep 17 00:00:00 2001
From: William Grant <willmgrant@gmail.com>
Date: Tue, 14 Jun 2022 15:57:39 +1000
Subject: [PATCH] fix: global error copy to clipboard option must not quit the
 app

this allows for easier debugging. The user must explicitly quit the app when the error window is shown using the quit button
---
 ts/node/global_errors.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ts/node/global_errors.ts b/ts/node/global_errors.ts
index 3d65b6623..621f66ce5 100644
--- a/ts/node/global_errors.ts
+++ b/ts/node/global_errors.ts
@@ -6,7 +6,7 @@ import { ConsoleCustom } from './logging'; // checked - only node
 
 // We use hard-coded strings until we're able to update these strings from the locale.
 let quitText = 'Quit';
-let copyErrorAndQuitText = 'Copy error and quit';
+let copyErrorAndQuitText = 'Copy error to clipboard';
 
 async function handleError(prefix: string, error: any) {
   if ((console as ConsoleCustom)._error) {
@@ -17,21 +17,21 @@ async function handleError(prefix: string, error: any) {
   if (app.isReady()) {
     // title field is not shown on macOS, so we don't use it
     const button = await dialog.showMessageBox({
-      buttons: [quitText, copyErrorAndQuitText],
+      buttons: [copyErrorAndQuitText, quitText],
       defaultId: 0,
       detail: redactAll(error.stack),
       message: prefix,
       noLink: true,
       type: 'error',
     });
-    if (button.response === 1) {
+    if (button.response === 0) {
       clipboard.writeText(`${prefix}\n\n${redactAll(error.stack)}`);
+    } else if (button.response === 1) {
+      app.exit(1);
     }
   } else {
     dialog.showErrorBox(prefix, error.stack);
   }
-
-  app.exit(1);
 }
 
 export const updateLocale = (messages: LocaleMessagesType) => {