fix: more comment cleanup

pull/2971/head
William Grant 2 years ago
parent 61d349ecc4
commit aad55025ba

@ -63,7 +63,7 @@ export const NoMessageInConversation = () => {
const isMe = useSelectedIsNoteToSelf();
const canWrite = useSelector(getSelectedCanWrite);
const privateBlindedAndBlockingMsgReqs = useSelectedHasDisabledBlindedMsgRequests();
// TODOLATER use this selector accross the whole application (left pane excluded)
// TODOLATER use this selector across the whole application (left pane excluded)
const nameToRender = useSelectedNicknameOrProfileNameOrShortenedPubkey();
if (!selectedConversation || hasMessage) {

@ -154,7 +154,6 @@ function updateContactInContactWrapper(
priority,
dbCreatedAtSeconds: Math.floor((contact.active_at || Date.now()) / 1000),
expirationMode: contact.expirationMode || 'off',
// TODO rename expireTimer to expirationTimer
expireTimer: contact.expireTimer || 0,
});

@ -427,7 +427,6 @@ function saveConversation(data: ConversationAttributes): SaveConversationReturn
zombies,
left,
expirationMode,
// TODO rename expireTimer to expirationTimer
expireTimer,
lastDisappearingMessageChangeTimestamp,
hasOutdatedClient,

@ -16,6 +16,7 @@ import { ConversationModel } from '../models/conversation';
import { ConversationTypeEnum } from '../models/conversationAttributes';
import { getSwarmPollingInstance } from '../session/apis/snode_api';
import { GetNetworkTime } from '../session/apis/snode_api/getNetworkTime';
import { SnodeNamespaces } from '../session/apis/snode_api/namespaces';
import { ClosedGroupEncryptionPairReplyMessage } from '../session/messages/outgoing/controlMessage/group/ClosedGroupEncryptionPairReplyMessage';
import { UserUtils } from '../session/utils';
@ -27,7 +28,6 @@ import { ConfigWrapperObjectTypes } from '../webworker/workers/browser/libsessio
import { getSettingsKeyFromLibsessionWrapper } from './configMessage';
import { ECKeyPair, HexKeyPair } from './keypairs';
import { queueAllCachedFromSource } from './receiver';
import { GetNetworkTime } from '../session/apis/snode_api/getNetworkTime';
export const distributingClosedGroupEncryptionKeyPairs = new Map<string, ECKeyPair>();
@ -301,7 +301,6 @@ export async function handleNewClosedGroup(
return;
}
const groupConvo = getConversationController().get(groupId);
// TODO Rename to expirationTimer
const expireTimer = groupUpdate.expirationTimer;
if (groupConvo) {

@ -442,7 +442,6 @@ export function getMessageReadyToDisappear(
const {
expirationType,
// TODO renamed expireTimer to expirationTimer
expirationTimer: expireTimer,
lastDisappearingMessageChangeTimestamp,
isLegacyConversationSettingMessage,

@ -11,7 +11,7 @@ export const DisappearingMessageConversationModes = [
// TODO legacy messages support will be removed in a future release
'legacy',
] as const;
export type DisappearingMessageConversationModeType = typeof DisappearingMessageConversationModes[number]; // TODO we should make this type a bit more hardcoded than being just resolved as a string
export type DisappearingMessageConversationModeType = typeof DisappearingMessageConversationModes[number];
// TODO legacy messages support will be removed in a future release
// expirationType and lastDisappearingMessageChangeTimestamp will no longer have an undefined option

@ -342,7 +342,6 @@ const buildSyncExpireTimerMessage = (
) => {
const {
expirationType,
// TODO rename expireTimer to expirationTimer
expirationTimer: expireTimer,
lastDisappearingMessageChangeTimestamp,
} = expireUpdate;

@ -3,8 +3,8 @@ import { pathExists } from 'fs-extra';
import { isString } from 'lodash';
import * as MIME from '../MIME';
import * as GoogleChrome from '../../util/GoogleChrome';
import * as MIME from '../MIME';
import { toLogFormat } from './Errors';
import {
@ -14,13 +14,13 @@ import {
writeNewAttachmentData,
} from '../MessageAttachment';
import {
THUMBNAIL_CONTENT_TYPE,
THUMBNAIL_SIDE,
getImageDimensions,
makeImageThumbnailBuffer,
makeObjectUrl,
makeVideoScreenshot,
revokeObjectUrl,
THUMBNAIL_CONTENT_TYPE,
THUMBNAIL_SIDE,
} from './VisualAttachment';
// Returns true if `rawAttachment` is a valid attachment based on our current schema.
@ -177,7 +177,6 @@ export const deleteData = async (attachment: {
throw new TypeError('deleteData: attachment is not valid');
}
// TODO verify this works correctly
let { path, thumbnail, screenshot } = attachment;
if (path && isString(path)) {

@ -1,8 +1,8 @@
import { GetNetworkTime } from '../session/apis/snode_api/getNetworkTime';
import { FEATURE_RELEASE_TIMESTAMPS } from '../session/constants';
import { ConfigurationSync } from '../session/utils/job_runners/jobs/ConfigurationSyncJob';
import { assertUnreachable } from '../types/sqlSharedTypes';
import { Storage } from './storage';
import { FEATURE_RELEASE_TIMESTAMPS } from '../session/constants';
let isDisappearingMessageFeatureReleased: boolean | undefined;
let isUserConfigLibsessionFeatureReleased: boolean | undefined;
@ -118,8 +118,7 @@ export const ReleasedFeatures = {
isDisappearMessageV2FeatureReleasedCached,
};
// DO NOT MERGE
// TODO Remove before PR
// TODO DO NOT MERGE Remove after QA
async function setIsFeatureReleased(featureName: FeatureNameTracked, value: boolean) {
await Storage.put(featureStorageItemId(featureName), value);
setIsFeatureReleasedCached(featureName, value);

3
ts/window.d.ts vendored

@ -105,8 +105,7 @@ declare global {
setAutoUpdateEnabled: (enabled: boolean) => void;
setZoomFactor: (newZoom: number) => void;
updateZoomFactor: () => void;
// DO NOT MERGE
// TODO Remove before PR
// TODO DO NOT MERGE Remove after QA
setIsFeatureReleased: (featureName: FeatureNameTracked, value: boolean) => Promise<void>;
Signal: any;

Loading…
Cancel
Save