From a4f0c5242f9476d411002c75f902c702c5fd1fa9 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Fri, 30 Mar 2018 17:20:08 -0400 Subject: [PATCH] Document why batch size is one --- js/modules/messages_data_migrator.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/modules/messages_data_migrator.js b/js/modules/messages_data_migrator.js index f97872389..5f7732d53 100644 --- a/js/modules/messages_data_migrator.js +++ b/js/modules/messages_data_migrator.js @@ -21,6 +21,11 @@ const { deferredToPromise } = require('./deferred_to_promise'); const MESSAGES_STORE_NAME = 'messages'; + +// WARNING: Valus higher than `1` can cause ‘Maximum IPC message size exceeded’ +// error message on messages (attachments) that are too large: +// - https://github.com/zincbase/zincdb/issues/17 +// - https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_database.cc?l=1157&rcl=9431dd78cdccecea92415c25babad70c217d57a4 const NUM_MESSAGES_PER_BATCH = 1; exports.processNext = async ({