From a3c80ad247c6a24461ef6f3885d8b2b15b3b9a2c Mon Sep 17 00:00:00 2001
From: William Grant <willmgrant@gmail.com>
Date: Thu, 4 Apr 2024 11:54:03 +1100
Subject: [PATCH] fix: legacy groups are unapproved so should allow all
 notifications

usually if its unapproved we cancel the notification until the request is accepted
---
 ts/models/conversation.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ts/models/conversation.ts b/ts/models/conversation.ts
index d4d5450b6..7474418c4 100644
--- a/ts/models/conversation.ts
+++ b/ts/models/conversation.ts
@@ -1739,9 +1739,11 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
       return;
     }
     const conversationId = this.id;
+    const isLegacyGroup = this.isGroup() && !this.isPublic() && this.id.startsWith('05');
 
     let friendRequestText;
-    if (!this.isApproved()) {
+    // NOTE: legacy groups are never approved, so we don't should not cancel notifications
+    if (!this.isApproved() && !isLegacyGroup) {
       window?.log?.info('notification cancelled for unapproved convo', this.idForLogging());
       const hadNoRequestsPrior =
         getConversationController()