Fixed up settings view.

Fix review issues.
pull/186/head
Mikunj 6 years ago
parent 7564e270f8
commit a1e4b740f2

@ -1102,17 +1102,22 @@
"message": "General",
"description": "Header for general options on the settings screen"
},
"sendLinkPreviews": {
"message": "Send Link Previews",
"linkPreviews": {
"message": "Link Previews",
"description":
"Option to control creation and send of link previews in setting screen"
},
"linkPreviewsDescription": {
"message":
"Enable local link previews (Restart for changes to take effect)",
"Previews are supported for Imgur, Instagram, Reddit, and YouTube links.",
"description":
"Additional detail provided for Link Previews option in settings screen"
},
"linkPreviewsSettingDescription": {
"message":
"Enable local link previews (Restart for changes to take effect).",
"description": "Description shown for the Link Preview option "
},
"spellCheckDescription": {
"message": "Enable spell check of text entered in message composition box",
"description": "Description of the media permission description"

@ -218,8 +218,9 @@
spellCheckHeader: i18n('spellCheck'),
spellCheckDescription: i18n('spellCheckDescription'),
blockedHeader: 'Blocked Users',
sendLinkPreviews: i18n('sendLinkPreviews'),
linkPreviews: i18n('linkPreviews'),
linkPreviewsDescription: i18n('linkPreviewsDescription'),
linkPreviewsSettingDescription: i18n('linkPreviewsSettingDescription'),
};
},
onClose() {

@ -308,10 +308,11 @@ MessageSender.prototype = {
const silent = false;
// Remove this when we add support for attachments
message.attachmentPointers = null;
message.preview = null;
message.attachments = [];
message.attachmentPointers = [];
message.preview = [];
if (message.quote) {
message.quote.attachments = null;
message.quote.attachments = [];
}
return Promise.all([

@ -98,11 +98,16 @@
<input type='checkbox' name='spell-check-setting' id='spell-check-setting' />
<label for='spell-check-setting'>{{ spellCheckDescription }}</label>
</div>
<div class='link-preview-setting'>
<input type='checkbox' name='link-preview-setting' id='link-preview-setting' />
<label for='link-preview-setting'>{{ linkPreviewsDescription }}</label>
</div>
<hr>
<h3>{{ linkPreviews }}</h3>
<div>{{ linkPreviewsDescription }}<div>
</br>
<div class='link-preview-setting'>
<input type='checkbox' name='link-preview-setting' id='link-preview-setting' />
<label for='link-preview-setting'>{{ linkPreviewsSettingDescription }}</label>
</div>
<hr>
<div class='permissions-setting'>
<h3>{{ permissions }}</h3>
<div class='media-permissions'>

Loading…
Cancel
Save