From a139299cd162e899c978f3042dbca0cf4270ce46 Mon Sep 17 00:00:00 2001 From: William Grant Date: Thu, 4 Apr 2024 11:59:04 +1100 Subject: [PATCH] fix: review feedback use isClosedGroup, update comment --- ts/models/conversation.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts/models/conversation.ts b/ts/models/conversation.ts index 7474418c4..096fd86d4 100644 --- a/ts/models/conversation.ts +++ b/ts/models/conversation.ts @@ -1739,10 +1739,10 @@ export class ConversationModel extends Backbone.Model { return; } const conversationId = this.id; - const isLegacyGroup = this.isGroup() && !this.isPublic() && this.id.startsWith('05'); + const isLegacyGroup = this.isClosedGroup() && this.id.startsWith('05'); let friendRequestText; - // NOTE: legacy groups are never approved, so we don't should not cancel notifications + // NOTE: legacy groups are never approved, so we should not cancel notifications if (!this.isApproved() && !isLegacyGroup) { window?.log?.info('notification cancelled for unapproved convo', this.idForLogging()); const hadNoRequestsPrior =