From 9e9fffd9d2b6c37f9259d9bc6db637fe9e5e32b9 Mon Sep 17 00:00:00 2001
From: William Grant <willmgrant@gmail.com>
Date: Wed, 12 Jun 2024 17:30:21 +1000
Subject: [PATCH] fix: name showHide button props more explcitly

---
 ts/components/inputs/SessionInput.tsx         | 26 +++++++++----------
 .../registration/stages/RestoreAccount.tsx    |  6 ++---
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/ts/components/inputs/SessionInput.tsx b/ts/components/inputs/SessionInput.tsx
index 30ba358ea..e6f26ab6a 100644
--- a/ts/components/inputs/SessionInput.tsx
+++ b/ts/components/inputs/SessionInput.tsx
@@ -160,13 +160,13 @@ const ErrorItem = (props: { id: string; error: string }) => {
   );
 };
 
-type ShowHideStrings = { hide: string; show: string };
+type ShowHideButtonStrings = { hide: string; show: string };
 type ShowHideButtonProps = {
   forceShow: boolean;
   toggleForceShow: () => void;
   error: boolean;
-  ariaLabels?: ShowHideStrings;
-  dataTestIds?: ShowHideStrings;
+  ariaLabels?: ShowHideButtonStrings;
+  dataTestIds?: ShowHideButtonStrings;
 };
 
 const ShowHideButton = (props: ShowHideButtonProps) => {
@@ -232,9 +232,9 @@ type Props = {
   inputRef?: RefObject<HTMLInputElement | HTMLTextAreaElement>;
   inputDataTestId?: string;
   id?: string;
-  enableShowHide?: boolean;
-  showHideAriaLabels?: ShowHideStrings;
-  showHideDataTestIds?: ShowHideStrings;
+  enableShowHideButton?: boolean;
+  showHideButtonAriaLabels?: ShowHideButtonStrings;
+  showHideButtonDataTestIds?: ShowHideButtonStrings;
   ctaButton?: ReactNode;
   monospaced?: boolean;
   textSize?: TextSizes;
@@ -261,9 +261,9 @@ export const SessionInput = (props: Props) => {
     inputRef,
     inputDataTestId,
     id = 'session-input-floating-label',
-    enableShowHide,
-    showHideAriaLabels,
-    showHideDataTestIds,
+    enableShowHideButton,
+    showHideButtonAriaLabels,
+    showHideButtonDataTestIds,
     ctaButton,
     monospaced,
     textSize,
@@ -307,7 +307,7 @@ export const SessionInput = (props: Props) => {
     tabIndex,
     ref: inputRef,
     onChange: updateInputValue,
-    style: { paddingInlineEnd: enableShowHide ? '48px' : undefined },
+    style: { paddingInlineEnd: enableShowHideButton ? '48px' : undefined },
     // just in case onChange isn't triggered
     onBlur: (event: ChangeEvent<HTMLInputElement>) => {
       if (editable && !disableOnBlurEvent) {
@@ -377,15 +377,15 @@ export const SessionInput = (props: Props) => {
             aria-label={ariaLabel || 'session input'}
           />
         )}
-        {editable && enableShowHide && (
+        {editable && enableShowHideButton && (
           <ShowHideButton
             forceShow={forceShow}
             toggleForceShow={() => {
               setForceShow(!forceShow);
             }}
             error={Boolean(errorString)}
-            ariaLabels={showHideAriaLabels}
-            dataTestIds={showHideDataTestIds}
+            ariaLabels={showHideButtonAriaLabels}
+            dataTestIds={showHideButtonDataTestIds}
           />
         )}
       </StyledBorder>
diff --git a/ts/components/registration/stages/RestoreAccount.tsx b/ts/components/registration/stages/RestoreAccount.tsx
index 10f8c22be..4e63a8384 100644
--- a/ts/components/registration/stages/RestoreAccount.tsx
+++ b/ts/components/registration/stages/RestoreAccount.tsx
@@ -241,12 +241,12 @@ export const RestoreAccount = () => {
                   }}
                   onEnterPressed={recoverAndFetchDisplayName}
                   error={recoveryPasswordError}
-                  enableShowHide={true}
-                  showHideAriaLabels={{
+                  enableShowHideButton={true}
+                  showHideButtonAriaLabels={{
                     hide: 'Hide recovery password toggle',
                     show: 'Reveal recovery password toggle',
                   }}
-                  showHideDataTestIds={{
+                  showHideButtonDataTestIds={{
                     hide: 'hide-recovery-phrase-toggle',
                     show: 'reveal-recovery-phrase-toggle',
                   }}