From 996f1d0cb1cb02387673f4aeb4a066ab3323247d Mon Sep 17 00:00:00 2001
From: William Grant <willmgrant@gmail.com>
Date: Mon, 22 May 2023 16:26:32 +1000
Subject: [PATCH] fix: disappearing modes loadDataTestId should return in
 switch cases

---
 .../disappearing-messages/DisappearingModes.tsx   | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/ts/components/conversation/right-panel/overlay/disappearing-messages/DisappearingModes.tsx b/ts/components/conversation/right-panel/overlay/disappearing-messages/DisappearingModes.tsx
index 12098063e..8b8349b4a 100644
--- a/ts/components/conversation/right-panel/overlay/disappearing-messages/DisappearingModes.tsx
+++ b/ts/components/conversation/right-panel/overlay/disappearing-messages/DisappearingModes.tsx
@@ -4,23 +4,18 @@ import { PanelButtonGroup, PanelLabel } from '../../../../buttons/PanelButton';
 import { PanelRadioButton } from '../../../../buttons/PanelRadioButton';
 
 function loadDataTestId(mode: DisappearingMessageConversationType) {
-  let dataTestId = 'disappear-%-option';
+  const dataTestId = 'disappear-%-option';
   switch (mode) {
     case 'legacy':
-      dataTestId = dataTestId.replace('%', 'legacy');
-      break;
+      return dataTestId.replace('%', 'legacy');
     case 'deleteAfterRead':
-      dataTestId = dataTestId.replace('%', 'after-read');
-      break;
+      return dataTestId.replace('%', 'after-read');
     case 'deleteAfterSend':
-      dataTestId = dataTestId.replace('%', 'after-send');
-      break;
+      return dataTestId.replace('%', 'after-send');
     case 'off':
     default:
-      dataTestId = dataTestId.replace('%', 'off');
+      return dataTestId.replace('%', 'off');
   }
-
-  return dataTestId;
 }
 
 type DisappearingModesProps = {