Merge pull request #2329 from Bilb/fix-replying-msg-with-attachments

fix: error when trying to reply to an attachment

ts/data/data.ts

@@ -90,6 +90,12 @@ function _cleanData(data: any): any {
       data[key] = value.map(_cleanData);
     } else if (_.isObject(value) && value instanceof File) {
       data[key] = { name: value.name, path: value.path, size: value.size, type: value.type };
+    } else if (_.isObject(value) && value instanceof ArrayBuffer) {
+      window.log.error(
+        'Trying to save an ArrayBuffer to the db is most likely an error. This specific field should be removed before the cleanData call'
+      );
+      /// just skip it
+      continue;
     } else if (_.isObject(value)) {
       data[key] = _cleanData(value);
     } else if (_.isBoolean(value)) {

ts/models/message.ts

@@ -1048,7 +1048,8 @@ export class MessageModel extends Backbone.Model<MessageAttributes> {
     }
 
     perfStart(`messageCommit-${this.attributes.id}`);
-    const id = await saveMessage(this.attributes);
+    // because the saving to db calls _cleanData which mutates the field for cleaning, we need to save a copy
+    const id = await saveMessage(_.cloneDeep(this.attributes));
     if (triggerUIUpdate) {
       this.dispatchMessageUpdate();
     }