From 91be687ff059dd331ed94a72df1205494beda090 Mon Sep 17 00:00:00 2001 From: yougotwill Date: Fri, 24 Jan 2025 16:00:34 +1100 Subject: [PATCH] feat: add build_macos job for testing uses macos-14 which is the minimum for arm64 builds, hoping it will build intel automatically, --- .github/workflows/build-binaries.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml index 2ac5dd6d3..83b52c3e9 100644 --- a/.github/workflows/build-binaries.yml +++ b/.github/workflows/build-binaries.yml @@ -116,10 +116,9 @@ jobs: if: ${{ env.SHOULD_PUBLISH == 'true' || env.SHOULD_PUBLISH_ALPHA == 'true' }} run: yarn build-release-publish # No other args needed for windows publish - # We want a mac arm64 build, and according to this https://github.com/actions/runner-images#available-images macos-14 is always arm64 - # macos-14 is disabled for now as we hit our free tier limit for macos builds - build_macos_x64: - runs-on: macos-13 + # We want both arm64 and intel mac builds, and according to this https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources macos-14 and above is always arm64 and macos-13 is the last intel runner + build_macos: + runs-on: macos-14 env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} MAC_CERTIFICATE: ${{ secrets.MAC_CERTIFICATE }} @@ -136,7 +135,7 @@ jobs: - name: Setup & Build uses: ./actions/setup_and_build with: - cache_suffix: 'macos_x64' + cache_suffix: 'macos' # we want to test on all platforms since some are testing the rendered menus (and are dependent on the platform) - name: Unit Test