From 9b204e4a8fe9aad1b83a45107fb4675a942db215 Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Sun, 9 Feb 2020 22:05:11 -0800 Subject: [PATCH 1/2] make sure invalid Pubkey is shown to the user and stop loader --- ts/components/session/RegistrationTabs.tsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ts/components/session/RegistrationTabs.tsx b/ts/components/session/RegistrationTabs.tsx index 75c46b50b..7c6b762a4 100644 --- a/ts/components/session/RegistrationTabs.tsx +++ b/ts/components/session/RegistrationTabs.tsx @@ -827,7 +827,10 @@ export class RegistrationTabs extends React.Component<{}, State> { const onError = async (error: any) => { window.log.error(error); - + // clear the ... to make sure the user realize we're not doing anything + this.setState({ + loading: false, + }); await this.resetRegistration(); }; @@ -839,7 +842,11 @@ export class RegistrationTabs extends React.Component<{}, State> { const validationError = c.validateNumber(); if (validationError) { onError('Invalid public key').ignore(); - + window.pushToast({ + title: window.i18n('invalidNumberError'), + type: 'error', + id: 'invalidNumberError', + }); return; } try { From 192fb3e382fd2322d8daf6a25895326368bffbfe Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Sun, 9 Feb 2020 23:12:15 -0800 Subject: [PATCH 2/2] add line break due to CI --- ts/components/session/RegistrationTabs.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/ts/components/session/RegistrationTabs.tsx b/ts/components/session/RegistrationTabs.tsx index 7c6b762a4..f70dd9f79 100644 --- a/ts/components/session/RegistrationTabs.tsx +++ b/ts/components/session/RegistrationTabs.tsx @@ -847,6 +847,7 @@ export class RegistrationTabs extends React.Component<{}, State> { type: 'error', id: 'invalidNumberError', }); + return; } try {