remove all the conditional rendering logic to make code cleaner

pull/905/head
Brian Jian Zhao 5 years ago
parent 0daaa04596
commit 75f5d5743f

@ -88,8 +88,7 @@ export class SessionSettingListItem extends React.Component<Props, State> {
/>
)}
{type === SessionSettingType.Slider &&
content.sliderCategory === 'messageTTLSlider' ? (
{type === SessionSettingType.Slider && (
<div className="slider-wrapper">
<Slider
dots={content.dotsEnable}
@ -103,28 +102,10 @@ export class SessionSettingListItem extends React.Component<Props, State> {
/>
<div className="slider-info">
<p>{`${currentSliderValue} Hours`}</p>
<p>{content.info(currentSliderValue)}</p>
</div>
</div>
) : type === SessionSettingType.Slider &&
content.sliderCategory === 'zoomFactorSlider' ? (
<div>
<Slider
dots={content.dotsEnable}
step={content.step}
min={content.min}
max={content.max}
defaultValue={currentSliderValue}
onChange={sliderValue => {
this.handleSlider(sliderValue);
}}
/>
<div className="slider-info">
<p>{`Zoom Level: %${currentSliderValue}`}</p>
</div>
</div>
) : null}
)}
</div>
</div>
);

@ -236,14 +236,10 @@ export class SettingsView extends React.Component<SettingsViewProps, State> {
{shouldRenderPasswordLock ? (
this.renderPasswordLock()
) : (
//
<div ref={this.settingsViewRef} className="session-settings-list">
{this.renderSettingInCategory()}
{/* what gets rendered back from calling renderSettingInCategory */}
</div>
)}
{/* session info is always shown in here */}
{this.renderSessionInfo()}
</div>
</div>
@ -451,6 +447,7 @@ export class SettingsView extends React.Component<SettingsViewProps, State> {
max: 96,
sliderCategory: 'messageTTLSlider',
defaultValue: 24,
info: (value: number) => `${value} Hours`,
},
confirmationDialogParams: undefined,
},
@ -471,6 +468,7 @@ export class SettingsView extends React.Component<SettingsViewProps, State> {
max: 200,
sliderCategory: 'zoomFactorSlider',
defaultValue: 100,
info: (value: number) => `Zoom Factor: ${value}%`
},
confirmationDialogParams: undefined,
},

Loading…
Cancel
Save