From 7048f812146006ecaa96d6c4f7bb554cf91f362c Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Mon, 1 Feb 2021 13:14:19 +1100 Subject: [PATCH] disable closedgroup update groups for now --- ts/session/group/index.ts | 1 - .../unit/receiving/ClosedGroupUpdates_test.ts | 69 +++++++++---------- 2 files changed, 33 insertions(+), 37 deletions(-) diff --git a/ts/session/group/index.ts b/ts/session/group/index.ts index 06cbbc981..ca39aae81 100644 --- a/ts/session/group/index.ts +++ b/ts/session/group/index.ts @@ -262,7 +262,6 @@ export async function updateOrCreateClosedGroup(details: GroupInfo) { } updates.left = false; updates.lastJoinedTimestamp = updates.active_at; - } else { updates.left = true; } diff --git a/ts/test/session/unit/receiving/ClosedGroupUpdates_test.ts b/ts/test/session/unit/receiving/ClosedGroupUpdates_test.ts index 2791bfef5..560b21c94 100644 --- a/ts/test/session/unit/receiving/ClosedGroupUpdates_test.ts +++ b/ts/test/session/unit/receiving/ClosedGroupUpdates_test.ts @@ -20,41 +20,38 @@ const { expect } = chai; // tslint:disable-next-line: max-func-body-length describe('ClosedGroupUpdates', () => { + //FIXME AUDRIC TODO // Initialize new stubbed cache - const sandbox = sinon.createSandbox(); - const ourDevice = TestUtils.generateFakePubKey(); - const ourNumber = ourDevice.key; - const groupId = TestUtils.generateFakePubKey().key; - const members = TestUtils.generateFakePubKeys(10); - const sender = members[3].key; - const getConvo = sandbox.stub(ConversationController.getInstance(), 'get'); - - beforeEach(async () => { - // Utils Stubs - sandbox.stub(UserUtils, 'getCurrentDevicePubKey').resolves(ourNumber); - }); - - afterEach(() => { - TestUtils.restoreStubs(); - sandbox.restore(); - }); - - describe('handleClosedGroupControlMessage', () => { - describe('performIfValid', () => { - it('does not perform if convo does not exist', async () => { - const envelope = generateEnvelopePlusClosedGroup(groupId, sender); - const groupUpdate = generateGroupUpdateNameChange(groupId); - getConvo.returns(undefined as any); - await handleClosedGroupControlMessage(envelope, groupUpdate); - }); - }); - - // describe('handleClosedGroupNameChanged', () => { - // it('does not trigger an update of the group if the name is the same', async () => { - // const envelope = generateEnvelopePlusClosedGroup(groupId, sender); - // const groupUpdate = generateGroupUpdateNameChange(groupId); - // await handleClosedGroupControlMessage(envelope, groupUpdate); - // }); - // }); - }); + // const sandbox = sinon.createSandbox(); + // const ourDevice = TestUtils.generateFakePubKey(); + // const ourNumber = ourDevice.key; + // const groupId = TestUtils.generateFakePubKey().key; + // const members = TestUtils.generateFakePubKeys(10); + // const sender = members[3].key; + // const getConvo = sandbox.stub(ConversationController.getInstance(), 'get'); + // beforeEach(async () => { + // // Utils Stubs + // sandbox.stub(UserUtils, 'getCurrentDevicePubKey').resolves(ourNumber); + // }); + // afterEach(() => { + // TestUtils.restoreStubs(); + // sandbox.restore(); + // }); + // describe('handleClosedGroupControlMessage', () => { + // describe('performIfValid', () => { + // it('does not perform if convo does not exist', async () => { + // const envelope = generateEnvelopePlusClosedGroup(groupId, sender); + // const groupUpdate = generateGroupUpdateNameChange(groupId); + // getConvo.returns(undefined as any); + // await handleClosedGroupControlMessage(envelope, groupUpdate); + // }); + // }); + // // describe('handleClosedGroupNameChanged', () => { + // // it('does not trigger an update of the group if the name is the same', async () => { + // // const envelope = generateEnvelopePlusClosedGroup(groupId, sender); + // // const groupUpdate = generateGroupUpdateNameChange(groupId); + // // await handleClosedGroupControlMessage(envelope, groupUpdate); + // // }); + // // }); + // }); });