From 6547538458663d56f89f01a1d0f67e4ccb8bbaa9 Mon Sep 17 00:00:00 2001 From: lilia Date: Wed, 23 Sep 2015 12:10:47 -0700 Subject: [PATCH] Use foreach instead of a loop This syntax makes plain that the function is not used anywhere else, and increases linearity/readability. // FREEBIE --- js/libtextsecure.js | 7 ++----- libtextsecure/sendmessage.js | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/js/libtextsecure.js b/js/libtextsecure.js index a37128b2c..5d3b9c93a 100644 --- a/js/libtextsecure.js +++ b/js/libtextsecure.js @@ -39891,7 +39891,7 @@ window.textsecure.messaging = function() { }); }; - var getDevicesAndSendToNumber = function(number) { + numbers.forEach(function(number) { textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) { return Promise.all(devicesForNumber.map(function(device) { return textsecure.protocol_wrapper.hasOpenSession(device.encodedNumber).then(function(result) { @@ -39911,10 +39911,7 @@ window.textsecure.messaging = function() { }); }); }); - }; - - for (var i in numbers) - getDevicesAndSendToNumber(numbers[i]); + }); } var sendIndividualProto = function(number, proto, timestamp) { diff --git a/libtextsecure/sendmessage.js b/libtextsecure/sendmessage.js index 2312507f4..8f0795e1a 100644 --- a/libtextsecure/sendmessage.js +++ b/libtextsecure/sendmessage.js @@ -210,7 +210,7 @@ window.textsecure.messaging = function() { }); }; - var getDevicesAndSendToNumber = function(number) { + numbers.forEach(function(number) { textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) { return Promise.all(devicesForNumber.map(function(device) { return textsecure.protocol_wrapper.hasOpenSession(device.encodedNumber).then(function(result) { @@ -230,10 +230,7 @@ window.textsecure.messaging = function() { }); }); }); - }; - - for (var i in numbers) - getDevicesAndSendToNumber(numbers[i]); + }); } var sendIndividualProto = function(number, proto, timestamp) {