From 5ffa265559dd5a5b48eeb07408cd3b6e9d7eb6a8 Mon Sep 17 00:00:00 2001
From: lilia <liliakai@gmail.com>
Date: Mon, 23 Mar 2015 11:19:02 -0700
Subject: [PATCH] Revert "Popout inbox"

This reverts commit 31e7d285e3f5cc0e74a5bdf8a0aa5c801b84d144.

This seemed like a nice feature, but the popup bubble isn't very
conducive to nontrivial user inputs, e.g. file inputs.

Fixes #211
---
 background.html          |   1 -
 images/popout.png        | Bin 451 -> 0 bytes
 js/background.js         |   2 ++
 js/index.js              |  15 +--------------
 js/panel_controller.js   |   6 ------
 js/views/inbox_view.js   |   4 ----
 manifest.json            |   3 +--
 stylesheets/_index.scss  |  14 --------------
 stylesheets/manifest.css |  11 -----------
 9 files changed, 4 insertions(+), 52 deletions(-)
 delete mode 100644 images/popout.png

diff --git a/background.html b/background.html
index c87572b35..c58352765 100644
--- a/background.html
+++ b/background.html
@@ -153,7 +153,6 @@
   <script type="text/x-tmpl-mustache" id="inbox">
     <div class='title-bar' id='header'>
       <div class='socket-status'></div>
-      <button class='popout hide'></button>
     </div>
     <div class='gutter'>
         <div class='conversations scrollable'></div>
diff --git a/images/popout.png b/images/popout.png
deleted file mode 100644
index 2f648740babaa774e1eff22a3c7b6d8f99a92f8c..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 451
zcmV;!0X+VRP)<h;3K|Lk000e1NJLTq000;O000;W1^@s6;CDUv00004b3#c}2nYxW
zd<bNS0004cNkl<ZNQvc?&q@MO6o<b%Gv+2F5Gmb6AdI>QT}N%gHoiy+3B5qCAZRbr
zsvxLE?KFz)4}s94!fKGB7MZB0)sUJqPUfn<-I;st@0{N~b1(cUlKGpdXrUe$r>5!-
z62*rTM3QbBE^}c8kSNq-SPp>Jvmz25sZAG*zId{~11Id9*w$T8>*#wxYEYgw=%ZJ9
z#1&U#EfCLJVXdPd0VxH?y53wETY-4q3Tt}n0Eh{cHKUoXWM`kpQot4$Fa^qn(Ohv7
zhwnpn#VlG8O<Mc5xWC;<pXTOX?DauEhi3<7(TW)T;u~M$PIz(<E!0Aqv~~nc;N0g^
zneNVQ?91nT(HuJW!=ZwCpfu5LES{~+Jb7tssDo&s9x$Z2D_|<9d_d;X!?ASZ>Y$nn
zzJl5YO1^eushSI0KM@~V0N`SMdb9m*EPEN~AchZFDY=HXQN-bwZ;=;z94N2^LT+!p
t2X4EAeg|3Laa3ic)V&C+qwfEwd;$ZehfLwTn>_#k002ovPDHLkV1fo%#P$FH

diff --git a/js/background.js b/js/background.js
index 00d60f958..858d6eb88 100644
--- a/js/background.js
+++ b/js/background.js
@@ -65,6 +65,8 @@
             });
         });
 
+        extension.browserAction(window.openInbox);
+
         // refresh views
         var views = extension.windows.getViews();
         for (var i = 0; i < views.length; ++i) {
diff --git a/js/index.js b/js/index.js
index 81cedf496..4b67276e4 100644
--- a/js/index.js
+++ b/js/index.js
@@ -20,23 +20,10 @@
 
     window.Whisper = window.Whisper || {};
     if (bg.textsecure.storage.getUnencrypted("number_id") === undefined) {
-        extension.navigator.tabs.create('/options.html');
-        window.close();
+        window.location = '/options.html';
     } else {
         new bg.Whisper.InboxView().$el.prependTo(bg.$('body',document));
         bg.textsecure.storage.putUnencrypted("unreadCount", 0);
         extension.navigator.setBadgeText("");
-
-        window.addEventListener('beforeunload', function () {
-            chrome.browserAction.setPopup({popup: 'index.html'}); // pop in
-        });
-
-        extension.windows.getCurrent(function (windowInfo) {
-            if (windowInfo.type === 'normal') {
-                bg.$('body', document).addClass('pop-in');
-            } else {
-                bg.$('.popout', document).remove();
-            }
-        });
     }
 }());
diff --git a/js/panel_controller.js b/js/panel_controller.js
index 0747db6a5..4e0f6d3d7 100644
--- a/js/panel_controller.js
+++ b/js/panel_controller.js
@@ -133,12 +133,6 @@
         }
     };
 
-    window.popoutInbox = function() {
-        chrome.browserAction.setPopup({popup: ''});
-        extension.browserAction(window.openInbox);
-        window.openInbox();
-    };
-
     // make sure windows are cleaned up on close
     extension.windows.onClosed(function (windowId) {
         if (windowMap.windowId[windowId]) {
diff --git a/js/views/inbox_view.js b/js/views/inbox_view.js
index bd86bbb3a..89f2b68ee 100644
--- a/js/views/inbox_view.js
+++ b/js/views/inbox_view.js
@@ -80,10 +80,6 @@
         events: {
             'click .fab': 'showCompose',
             'select .contact': 'openConversation',
-            'click .popout': 'popout'
-        },
-        popout: function() {
-            bg.popoutInbox();
         },
         openConversation: function(e, data) {
             bg.openConversation(data.modelId);
diff --git a/manifest.json b/manifest.json
index 3ce1a8699..1dc8c7085 100644
--- a/manifest.json
+++ b/manifest.json
@@ -16,8 +16,7 @@
         "default_icon": {
             "19": "images/icon.png"
         },
-        "default_title": "TextSecure",
-        "default_popup": "index.html"
+        "default_title": "TextSecure"
     },
 
     "background": {
diff --git a/stylesheets/_index.scss b/stylesheets/_index.scss
index 267576502..c0ba5f8dc 100644
--- a/stylesheets/_index.scss
+++ b/stylesheets/_index.scss
@@ -95,11 +95,6 @@ input.search {
 }
 
 .index {
-  &.pop-in {
-    min-height: 330px;
-    min-width: 260px;
-  }
-
   color: $grey_d;
   background: #eee;
 
@@ -141,12 +136,3 @@ input.search {
       font-weight: bold;
     }
 }
-
-.popout {
-  float: right;
-  background: url('/images/popout.png') no-repeat center center;
-  display: none;
-}
-.title-bar:hover .popout {
-  display: inline-block;
-}
diff --git a/stylesheets/manifest.css b/stylesheets/manifest.css
index 0d649d827..d131842b4 100644
--- a/stylesheets/manifest.css
+++ b/stylesheets/manifest.css
@@ -320,9 +320,6 @@ input.search {
 .index {
   color: #454545;
   background: #eee; }
-  .index.pop-in {
-    min-height: 330px;
-    min-width: 260px; }
   .index .new-group-update-form {
     display: none;
     padding: 0.5em; }
@@ -349,14 +346,6 @@ input.search {
 .conversations .unread .contact-details .last-timestamp {
   font-weight: bold; }
 
-.popout {
-  float: right;
-  background: url("/images/popout.png") no-repeat center center;
-  display: none; }
-
-.title-bar:hover .popout {
-  display: inline-block; }
-
 .conversation {
   padding: 36px 0; }
   .conversation .file-input .close {