From 5e6d3156f9f736a4cb0fabbe15d0d8299e77ba49 Mon Sep 17 00:00:00 2001 From: Lilia Date: Tue, 3 Oct 2017 20:08:06 +0200 Subject: [PATCH] Ensure locale is 'en' when NODE_ENV=test (#1527) Beacause so many of our tests have hardcoded english strings. We could do better, but for now anyone running tests locally must simply do so in english, even if they usually use Signal in another language. // FREEBIE --- app/locale.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/locale.js b/app/locale.js index 7b0de1d1c..b3e7bea0e 100644 --- a/app/locale.js +++ b/app/locale.js @@ -28,14 +28,19 @@ function getLocaleMessages(locale) { } function load() { - var english = getLocaleMessages('en'); + let english = getLocaleMessages('en'); + let appLocale = app.getLocale(); + + if (process.env.NODE_ENV === 'test') { + appLocale = 'en'; + } // Load locale - if we can't load messages for the current locale, we // default to 'en' // // possible locales: // https://github.com/electron/electron/blob/master/docs/api/locales.md - let localeName = normalizeLocaleName(app.getLocale()); + let localeName = normalizeLocaleName(appLocale); let messages; try {