fix: legacy group with wrapper and disable right click while searching

package.json

@@ -98,7 +98,7 @@
     "glob": "7.1.2",
     "image-type": "^4.1.0",
     "ip2country": "1.0.1",
-    "libsession_util_nodejs": "https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.14/libsession_util_nodejs-v0.1.14.tar.gz",
+    "libsession_util_nodejs": "https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.15/libsession_util_nodejs-v0.1.15.tar.gz",
     "libsodium-wrappers-sumo": "^0.7.9",
     "linkify-it": "3.0.2",
     "lodash": "^4.17.20",

ts/components/menu/ConversationHeaderMenu.tsx

@@ -42,6 +42,7 @@ import {
   DeletePrivateConversationMenuItem,
 } from './Menu';
 import { ContextConversationProvider } from '../leftpane/conversation-list-item/ConvoIdContext';
+import { isSearching } from '../../state/selectors/search';
 
 export type PropsConversationHeaderMenu = {
   triggerId: string;
@@ -53,10 +54,14 @@ export const ConversationHeaderMenu = (props: PropsConversationHeaderMenu) => {
   const convoId = useSelectedConversationKey();
   const isPrivateFriend = useSelectedIsPrivateFriend();
   const isPrivate = useSelectedIsPrivate();
+  const isSearchingMode = useSelector(isSearching);
 
   if (!convoId) {
     throw new Error('convoId must be set for a header to be visible!');
   }
+  if (isSearchingMode) {
+    return null;
+  }
 
   // we do not want the triple dots menu at all if this is not a friend at all
   if (isPrivate && !isPrivateFriend) {

ts/components/menu/ConversationListItemContextMenu.tsx

@@ -28,6 +28,7 @@ import {
   UnbanMenuItem,
   DeletePrivateConversationMenuItem,
 } from './Menu';
+import { isSearching } from '../../state/selectors/search';
 
 export type PropsContextConversationItem = {
   triggerId: string;
@@ -35,7 +36,11 @@ export type PropsContextConversationItem = {
 
 const ConversationListItemContextMenu = (props: PropsContextConversationItem) => {
   const { triggerId } = props;
+  const isSearchingMode = useSelector(isSearching);
 
+  if (isSearchingMode) {
+    return null;
+  }
   return (
     <SessionContextMenuContainer>
       <Menu id={triggerId} animation={animation.fade}>

ts/mains/main_renderer.tsx

@@ -198,7 +198,6 @@ Storage.onready(async () => {
     }
     await initialiseEmojiData(nativeEmojiData);
     await AttachmentDownloads.initAttachmentPaths();
-    await startJobRunners();
 
     await Promise.all([
       getConversationController().load(),
@@ -206,6 +205,7 @@ Storage.onready(async () => {
       OpenGroupData.opengroupRoomsLoad(),
       loadKnownBlindedKeys(),
     ]);
+    await startJobRunners();
   } catch (error) {
     window.log.error(
       'main_renderer: ConversationController failed to load:',

ts/models/message.ts

@@ -447,10 +447,12 @@ export class MessageModel extends Backbone.Model<MessageAttributes> {
       return 'read';
     }
     const sent = this.get('sent');
-    // control messages we've sent, synced from the network appear to just have the sent_at field set.
-    const sentAt = this.get('sent_at');
+    // control messages we've sent, synced from the network appear to just have the sent_at field set, but our current devices also have this field set when we are just sending it... So idk how to have behavior work fine.,
+    // TODOLATER
+    // const sentAt = this.get('sent_at');
     const sentTo = this.get('sent_to') || [];
-    if (sent || sentTo.length > 0 || sentAt) {
+
+    if (sent || sentTo.length > 0) {
       return 'sent';
     }
 

ts/node/migration/sessionMigrations.ts

@@ -34,7 +34,9 @@ import {
 
 import { getIdentityKeys, sqlNode } from '../sql';
 
-// tslint:disable: no-console quotemark one-variable-per-declaration
+const hasDebugEnvVariable = Boolean(process.env.SESSION_DEBUG);
+
+// tslint:disable: no-console quotemark one-variable-per-declaration no-unused-expression
 
 function getSessionSchemaVersion(db: BetterSqlite3.Database) {
   const result = db
@@ -1237,7 +1239,7 @@ function insertContactIntoContactWrapper(
     });
 
     try {
-      console.info('Inserting contact into wrapper: ', wrapperContact);
+      hasDebugEnvVariable && console.info('Inserting contact into wrapper: ', wrapperContact);
       contactsConfigWrapper.set(wrapperContact);
     } catch (e) {
       console.error(
@@ -1245,7 +1247,7 @@ function insertContactIntoContactWrapper(
       );
       // the wrapper did not like something. Try again with just the boolean fields as it's most likely the issue is with one of the strings (which could be recovered)
       try {
-        console.info('Inserting edited contact into wrapper: ', contact.id);
+        hasDebugEnvVariable && console.info('Inserting edited contact into wrapper: ', contact.id);
         contactsConfigWrapper.set(
           getContactInfoFromDBValues({
             id: contact.id,
@@ -1286,7 +1288,8 @@ function insertContactIntoContactWrapper(
 
     const maxRead = rows?.max_sent_at;
     const lastRead = isNumber(maxRead) && isFinite(maxRead) ? maxRead : 0;
-    console.info(`Inserting contact into volatile wrapper maxread: ${contact.id} :${lastRead}`);
+    hasDebugEnvVariable &&
+      console.info(`Inserting contact into volatile wrapper maxread: ${contact.id} :${lastRead}`);
     volatileConfigWrapper.set1o1(contact.id, lastRead, false);
   } catch (e) {
     console.error(
@@ -1305,6 +1308,7 @@ function insertCommunityIntoWrapper(
   const convoId = community.id; // the id of a conversation has the prefix, the serverUrl and the roomToken already present, but not the pubkey
 
   const roomDetails = sqlNode.getV2OpenGroupRoom(convoId, db);
+  hasDebugEnvVariable && console.info('insertCommunityIntoWrapper: ', community);
 
   if (
     !roomDetails ||
@@ -1320,9 +1324,10 @@ function insertCommunityIntoWrapper(
     );
     return;
   }
-  console.info(
-    `building fullUrl from serverUrl:"${roomDetails.serverUrl}" roomId:"${roomDetails.roomId}" pubkey:"${roomDetails.serverPublicKey}"`
-  );
+  hasDebugEnvVariable ??
+    console.info(
+      `building fullUrl from serverUrl:"${roomDetails.serverUrl}" roomId:"${roomDetails.roomId}" pubkey:"${roomDetails.serverPublicKey}"`
+    );
 
   const fullUrl = userGroupConfigWrapper.buildFullUrlFromDetails(
     roomDetails.serverUrl,
@@ -1335,7 +1340,7 @@ function insertCommunityIntoWrapper(
   });
 
   try {
-    console.info('Inserting community into group wrapper: ', wrapperComm);
+    hasDebugEnvVariable && console.info('Inserting community into group wrapper: ', wrapperComm);
     userGroupConfigWrapper.setCommunityByFullUrl(wrapperComm.fullUrl, wrapperComm.priority);
     const rows = db
       .prepare(
@@ -1353,7 +1358,10 @@ function insertCommunityIntoWrapper(
 
     const maxRead = rows?.max_sent_at;
     const lastRead = isNumber(maxRead) && isFinite(maxRead) ? maxRead : 0;
-    console.info(`Inserting community into volatile wrapper: ${wrapperComm.fullUrl} :${lastRead}`);
+    hasDebugEnvVariable &&
+      console.info(
+        `Inserting community into volatile wrapper: ${wrapperComm.fullUrl} :${lastRead}`
+      );
     volatileConfigWrapper.setCommunityByFullUrl(wrapperComm.fullUrl, lastRead, false);
   } catch (e) {
     console.error(
@@ -1399,7 +1407,8 @@ function insertLegacyGroupIntoWrapper(
   });
 
   try {
-    console.info('Inserting legacy group into wrapper: ', wrapperLegacyGroup);
+    hasDebugEnvVariable &&
+      console.info('Inserting legacy group into wrapper: ', wrapperLegacyGroup);
     userGroupConfigWrapper.setLegacyGroup(wrapperLegacyGroup);
 
     const rows = db
@@ -1418,7 +1427,8 @@ function insertLegacyGroupIntoWrapper(
 
     const maxRead = rows?.max_sent_at;
     const lastRead = isNumber(maxRead) && isFinite(maxRead) ? maxRead : 0;
-    console.info(`Inserting legacy group into volatile wrapper maxread: ${id} :${lastRead}`);
+    hasDebugEnvVariable &&
+      console.info(`Inserting legacy group into volatile wrapper maxread: ${id} :${lastRead}`);
     volatileInfoConfigWrapper.setLegacyGroup(id, lastRead, false);
   } catch (e) {
     console.error(
@@ -1434,7 +1444,7 @@ function getBlockedNumbersDuringMigration(db: BetterSqlite3.Database) {
       return [];
     }
     const foundBlocked = blockedItem?.value;
-    console.info('foundBlockedNumbers during migration', foundBlocked);
+    hasDebugEnvVariable && console.info('foundBlockedNumbers during migration', foundBlocked);
     if (isArray(foundBlocked)) {
       return foundBlocked;
     }
@@ -1557,6 +1567,13 @@ function updateToSessionSchemaVersion30(currentVersion: number, db: BetterSqlite
       ).run({ newId, oldConvoId: convoDetails.oldConvoId });
     });
 
+    // priority was isPinned before. Make sure that it was set to something, rather than allowing null values.
+    db.prepare(
+      `UPDATE ${CONVERSATIONS_TABLE} SET
+        priority = ${CONVERSATION_PRIORITIES.default}
+        WHERE priority IS NULL;`
+    ).run({});
+
     writeSessionSchemaVersion(targetVersion, db);
   })();
 
@@ -1657,12 +1674,7 @@ function updateToSessionSchemaVersion31(currentVersion: number, db: BetterSqlite
 
       if (isArray(contactsToWriteInWrapper) && contactsToWriteInWrapper.length) {
         console.info(
-          '===================== Starting contact inserting into wrapper ======================='
-        );
-
-        console.info(
-          'Writing contacts to wrapper during migration. length: ',
-          contactsToWriteInWrapper?.length
+          `===================== Starting contact inserting into wrapper ${contactsToWriteInWrapper?.length} =======================`
         );
 
         contactsToWriteInWrapper.forEach(contact => {
@@ -1743,7 +1755,8 @@ function updateToSessionSchemaVersion31(currentVersion: number, db: BetterSqlite
 
         legacyGroupsToWriteInWrapper.forEach(legacyGroup => {
           try {
-            console.info('Writing legacy group: ', JSON.stringify(legacyGroup));
+            hasDebugEnvVariable &&
+              console.info('Writing legacy group: ', JSON.stringify(legacyGroup));
 
             insertLegacyGroupIntoWrapper(
               legacyGroup,

ts/receiver/closedGroups.ts

@@ -298,7 +298,6 @@ export async function handleNewClosedGroup(
     members: members,
     admins,
     activeAt: envelopeTimestamp,
-    weWereJustAdded: true,
   };
 
   // be sure to call this before sending the message.

ts/receiver/configMessage.ts

@@ -1,9 +1,10 @@
+import { ContactInfo } from 'libsession_util_nodejs';
 import { compact, difference, isEmpty, isNumber, toNumber } from 'lodash';
 import { ConfigDumpData } from '../data/configDump/configDump';
 import { Data } from '../data/data';
 import { SettingsKey } from '../data/settings-key';
 import { ConversationInteraction } from '../interactions';
-import { ConversationTypeEnum } from '../models/conversationAttributes';
+import { CONVERSATION_PRIORITIES, ConversationTypeEnum } from '../models/conversationAttributes';
 import { SignalService } from '../protobuf';
 import { ClosedGroup } from '../session';
 import {
@@ -22,9 +23,11 @@ import { UserUtils } from '../session/utils';
 import { toHex } from '../session/utils/String';
 import { ConfigurationSync } from '../session/utils/job_runners/jobs/ConfigurationSyncJob';
 import { IncomingConfResult, LibSessionUtil } from '../session/utils/libsession/libsession_utils';
+import { SessionUtilContact } from '../session/utils/libsession/libsession_utils_contacts';
 import { SessionUtilConvoInfoVolatile } from '../session/utils/libsession/libsession_utils_convo_info_volatile';
 import { SessionUtilUserGroups } from '../session/utils/libsession/libsession_utils_user_groups';
 import { configurationMessageReceived, trigger } from '../shims/events';
+import { getCurrentlySelectedConversationOutsideRedux } from '../state/selectors/conversations';
 import { assertUnreachable } from '../types/sqlSharedTypes';
 import { BlockedNumberController } from '../util';
 import { Registration } from '../util/registration';
@@ -47,9 +50,7 @@ import { addKeyPairToCacheAndDBIfNeeded, handleNewClosedGroup } from './closedGr
 import { HexKeyPair } from './keypairs';
 import { queueAllCachedFromSource } from './receiver';
 import { EnvelopePlus } from './types';
-import { SessionUtilContact } from '../session/utils/libsession/libsession_utils_contacts';
-import { ContactInfo } from 'libsession_util_nodejs';
-import { getCurrentlySelectedConversationOutsideRedux } from '../state/selectors/conversations';
+import { deleteAllMessagesByConvoIdNoConfirmation } from '../interactions/conversationInteractions';
 
 function groupByVariant(
   incomingConfigs: Array<IncomingMessage<SignalService.ISharedConfigMessage>>
@@ -228,7 +229,14 @@ async function handleContactsUpdate(result: IncomingConfResult): Promise<Incomin
         changes = true;
       }
 
-      if (wrapperConvo.priority !== contactConvo.get('priority')) {
+      const currentPriority = contactConvo.get('priority');
+      if (wrapperConvo.priority !== currentPriority) {
+        if (wrapperConvo.priority === CONVERSATION_PRIORITIES.hidden) {
+          window.log.info(
+            'contact marked as hidden and was not before. Deleting all messages from that user'
+          );
+          await deleteAllMessagesByConvoIdNoConfirmation(wrapperConvo.id);
+        }
         await contactConvo.setPriorityFromWrapper(wrapperConvo.priority);
         changes = true;
       }
@@ -426,6 +434,7 @@ async function handleLegacyGroupUpdate(latestEnvelopeTimestamp: number) {
       ConversationTypeEnum.GROUP
     );
   }
+
   for (let index = 0; index < allLegacyGroupsInWrapper.length; index++) {
     const fromWrapper = allLegacyGroupsInWrapper[index];
 
@@ -453,7 +462,6 @@ async function handleLegacyGroupUpdate(latestEnvelopeTimestamp: number) {
         legacyGroupConvo.get('active_at') < latestEnvelopeTimestamp
           ? legacyGroupConvo.get('active_at')
           : latestEnvelopeTimestamp,
-      weWereJustAdded: false, // TODOLATER to remove once legacy groups support is dropped
     };
 
     await ClosedGroup.updateOrCreateClosedGroup(groupDetails);
@@ -461,8 +469,11 @@ async function handleLegacyGroupUpdate(latestEnvelopeTimestamp: number) {
     let changes = await legacyGroupConvo.setPriorityFromWrapper(fromWrapper.priority, false);
 
     const existingTimestampMs = legacyGroupConvo.get('lastJoinedTimestamp');
-    if (Math.floor(existingTimestampMs / 1000) !== fromWrapper.joinedAtSeconds) {
-      legacyGroupConvo.set({ lastJoinedTimestamp: fromWrapper.joinedAtSeconds * 1000 });
+    const existingJoinedAtSeconds = Math.floor(existingTimestampMs / 1000);
+    if (existingJoinedAtSeconds !== fromWrapper.joinedAtSeconds) {
+      legacyGroupConvo.set({
+        lastJoinedTimestamp: fromWrapper.joinedAtSeconds * 1000,
+      });
       changes = true;
     }
 
@@ -729,7 +740,6 @@ async function handleConfigMessagesViaLibSession(
   );
 
   const incomingMergeResult = await mergeConfigsWithIncomingUpdates(configMessages);
-
   await processMergingResults(incomingMergeResult);
 }
 

ts/session/apis/snode_api/expire.ts

@@ -224,7 +224,7 @@ export async function expireMessageOnSnode(props: ExpireMessageOnSnodeProps) {
 
   try {
     // TODO make this whole function `expireMessageOnSnode` retry
-    const successfulSend = await expireOnNodes(snode, params);
+    await expireOnNodes(snode, params);
   } catch (e) {
     const snodeStr = snode ? `${snode.ip}:${snode.port}` : 'null';
     window?.log?.warn(

ts/session/conversations/ConversationController.ts

@@ -1,7 +1,10 @@
 import { Data } from '../../data/data';
 import { OpenGroupData } from '../../data/opengroups';
 import { ConversationCollection, ConversationModel } from '../../models/conversation';
-import { actions as conversationActions } from '../../state/ducks/conversations';
+import {
+  actions as conversationActions,
+  resetConversationExternal,
+} from '../../state/ducks/conversations';
 import { BlockedNumberController } from '../../util';
 import { getOpenGroupManager } from '../apis/open_group_api/opengroupV2/OpenGroupManagerV2';
 import { getSwarmFor } from '../apis/snode_api/snodePool';
@@ -25,6 +28,7 @@ import { SnodeNamespaces } from '../apis/snode_api/namespaces';
 import { ClosedGroupMemberLeftMessage } from '../messages/outgoing/controlMessage/group/ClosedGroupMemberLeftMessage';
 import { UserUtils } from '../utils';
 import { isEmpty, isNil } from 'lodash';
+import { getCurrentlySelectedConversationOutsideRedux } from '../../state/selectors/conversations';
 
 let instance: ConversationController | null;
 
@@ -252,7 +256,14 @@ export class ConversationController {
           if (SessionUtilContact.isContactToStoreInWrapper(conversation)) {
             window.log.warn('isContactToStoreInWrapper still true for ', conversation.attributes);
           }
-          await SessionUtilContact.removeContactFromWrapper(conversation.id); // then remove the entry alltogether from the wrapper
+          if (conversation.id.startsWith('05')) {
+            // make sure to filter blinded contacts as it will throw otherwise
+            await SessionUtilContact.removeContactFromWrapper(conversation.id); // then remove the entry alltogether from the wrapper
+            await SessionUtilConvoInfoVolatile.removeContactFromWrapper(conversation.id);
+          }
+          if (getCurrentlySelectedConversationOutsideRedux() === conversation.id) {
+            window.inboxStore?.dispatch(resetConversationExternal());
+          }
         }
 
         break;

ts/session/group/closed-group.ts

@@ -14,7 +14,7 @@ import {
   distributingClosedGroupEncryptionKeyPairs,
 } from '../../receiver/closedGroups';
 import { ECKeyPair } from '../../receiver/keypairs';
-import { BlockedNumberController } from '../../util/blockedNumberController';
+import { GetNetworkTime } from '../apis/snode_api/getNetworkTime';
 import { SnodeNamespaces } from '../apis/snode_api/namespaces';
 import { getConversationController } from '../conversations';
 import { generateCurve25519KeyPairWithoutPrefix } from '../crypto';
@@ -26,7 +26,6 @@ import { ClosedGroupNewMessage } from '../messages/outgoing/controlMessage/group
 import { ClosedGroupRemovedMembersMessage } from '../messages/outgoing/controlMessage/group/ClosedGroupRemovedMembersMessage';
 import { UserUtils } from '../utils';
 import { fromHexToArray, toHex } from '../utils/String';
-import { GetNetworkTime } from '../apis/snode_api/getNetworkTime';
 
 export type GroupInfo = {
   id: string;
@@ -35,9 +34,7 @@ export type GroupInfo = {
   zombies?: Array<string>;
   activeAt?: number;
   expireTimer?: number | null;
-  blocked?: boolean;
   admins?: Array<string>;
-  weWereJustAdded?: boolean;
 };
 
 export interface GroupDiff extends MemberChanges {
@@ -208,7 +205,7 @@ function buildGroupDiff(convo: ConversationModel, update: GroupInfo): GroupDiff
 }
 
 export async function updateOrCreateClosedGroup(details: GroupInfo) {
-  const { id, weWereJustAdded, expireTimer } = details;
+  const { id, expireTimer } = details;
 
   const conversation = await getConversationController().getOrCreateAndWait(
     id,
@@ -217,7 +214,7 @@ export async function updateOrCreateClosedGroup(details: GroupInfo) {
 
   const updates: Pick<
     ConversationAttributes,
-    'type' | 'members' | 'displayNameInProfile' | 'active_at' | 'left' | 'lastJoinedTimestamp'
+    'type' | 'members' | 'displayNameInProfile' | 'active_at' | 'left'
   > = {
     displayNameInProfile: details.name,
     members: details.members,
@@ -225,17 +222,11 @@ export async function updateOrCreateClosedGroup(details: GroupInfo) {
     type: ConversationTypeEnum.GROUP,
     active_at: details.activeAt ? details.activeAt : 0,
     left: details.activeAt ? false : true,
-    lastJoinedTimestamp: details.activeAt && weWereJustAdded ? Date.now() : details.activeAt || 0,
   };
 
   conversation.set(updates);
   await conversation.unhideIfNeeded(false);
 
-  const isBlocked = details.blocked || false;
-  if (conversation.isClosedGroup()) {
-    await BlockedNumberController.setBlocked(conversation.id as string, isBlocked);
-  }
-
   if (details.admins?.length) {
     await conversation.updateGroupAdmins(details.admins, false);
   }

ts/session/utils/libsession/libsession_utils_contacts.ts

@@ -73,6 +73,7 @@ async function insertContactFromDBIntoWrapperAndRefresh(id: string): Promise<voi
   });
 
   try {
+    window.log.debug('inserting into contact wrapper: ', JSON.stringify(wrapperContact));
     await ContactsWrapperActions.set(wrapperContact);
   } catch (e) {
     window.log.warn(`ContactsWrapperActions.set of ${id} failed with ${e.message}`);

ts/session/utils/libsession/libsession_utils_convo_info_volatile.ts

@@ -78,7 +78,7 @@ async function insertConvoFromDBIntoWrapperAndRefresh(convoId: string): Promise<
       : 0;
 
   window.log.debug(
-    `convoInfoVolatile:insert "${convoId}";lastMessageReadTimestamp:${lastReadMessageTimestamp};forcedUnread:${isForcedUnread}...`
+    `inserting into convoVolatile wrapper: ${convoId} lastMessageReadTimestamp:${lastReadMessageTimestamp} forcedUnread:${isForcedUnread}...`
   );
 
   const convoType = getConvoType(foundConvo);
@@ -242,6 +242,18 @@ async function removeLegacyGroupFromWrapper(convoId: string) {
   mappedLegacyGroupWrapperValues.delete(convoId);
 }
 
+/**
+ * Removes the matching legacy group from the wrapper and from the cached list of legacy groups
+ */
+async function removeContactFromWrapper(convoId: string) {
+  try {
+    await ConvoInfoVolatileWrapperActions.erase1o1(convoId);
+  } catch (e) {
+    window.log.warn('removeContactFromWrapper failed with ', e.message);
+  }
+  mapped1o1WrapperValues.delete(convoId);
+}
+
 /**
  * This function can be used where there are things to do for all the types handled by this wrapper.
  * You can do a loop on all the types handled by this wrapper and have a switch using assertUnreachable to get errors when not every case is handled.
@@ -262,7 +274,7 @@ export const SessionUtilConvoInfoVolatile = {
   getVolatileInfoCached,
 
   // 1o1
-  // at the moment, we cannot remove a contact from the conversation volatile info so there is nothing here
+  removeContactFromWrapper,
 
   // legacy group
   removeLegacyGroupFromWrapper, // a group can be removed but also just marked hidden, so only call this function when the group is completely removed // TODOLATER

ts/session/utils/libsession/libsession_utils_user_groups.ts

@@ -10,7 +10,6 @@ import {
 import { UserGroupsWrapperActions } from '../../../webworker/workers/browser/libsession_worker_interface';
 import { OpenGroupUtils } from '../../apis/open_group_api/utils';
 import { getConversationController } from '../../conversations';
-import { isEmpty } from 'lodash';
 
 /**
  * The key of this map is the convoId as stored in the database.
@@ -101,7 +100,7 @@ async function insertGroupsFromDBIntoWrapperAndRefresh(convoId: string): Promise
       });
 
       try {
-        window.log.debug(`inserting into usergroup wrapper "${wrapperComm.fullUrl}"...`);
+        window.log.debug(`inserting into usergroup wrapper "${JSON.stringify(wrapperComm)}"...`);
         // this does the create or the update of the matching existing community
         await UserGroupsWrapperActions.setCommunityByFullUrl(
           wrapperComm.fullUrl,
@@ -129,23 +128,12 @@ async function insertGroupsFromDBIntoWrapperAndRefresh(convoId: string): Promise
       });
 
       try {
-        window.log.debug(`inserting into usergroup wrapper "${foundConvo.id}"... }`);
-
+        window.log.debug(
+          `inserting into usergroup wrapper "${foundConvo.id}"... }`,
+          JSON.stringify(wrapperLegacyGroup)
+        );
         // this does the create or the update of the matching existing legacy group
-        if (
-          !isEmpty(wrapperLegacyGroup.name) &&
-          !isEmpty(wrapperLegacyGroup.encPubkey) &&
-          !isEmpty(wrapperLegacyGroup.encSeckey)
-        ) {
-          window.log.debug('inserting into user wrapper', wrapperLegacyGroup);
-          await UserGroupsWrapperActions.setLegacyGroup(wrapperLegacyGroup);
-        } else {
-          window.log.debug(
-            'not inserting legacy group as name, or encryption keypair is empty',
-            foundConvo.id
-          );
-        }
-
+        await UserGroupsWrapperActions.setLegacyGroup(wrapperLegacyGroup);
         await refreshCachedUserGroup(convoId);
       } catch (e) {
         window.log.warn(`UserGroupsWrapperActions.set of ${convoId} failed with ${e.message}`);

ts/session/utils/libsession/libsession_utils_user_profile.ts

@@ -19,19 +19,20 @@ async function insertUserProfileIntoWrapper(convoId: string) {
   const dbName = ourConvo.get('displayNameInProfile') || '';
   const dbProfileUrl = ourConvo.get('avatarPointer') || '';
   const dbProfileKey = fromHexToArray(ourConvo.get('profileKey') || '');
+  const priority = ourConvo.get('priority') || CONVERSATION_PRIORITIES.default;
 
-  if (dbProfileUrl && !isEmpty(dbProfileKey)) {
-    await UserConfigWrapperActions.setUserInfo(
-      dbName,
-      ourConvo.get('priority') || CONVERSATION_PRIORITIES.default,
+  window.log.debug(
+    `inserting into userprofile wrapper: username:"${dbName}", priority:${priority} image:${JSON.stringify(
       { url: dbProfileUrl, key: dbProfileKey }
-    );
+    )} `
+  );
+  if (dbProfileUrl && !isEmpty(dbProfileKey)) {
+    await UserConfigWrapperActions.setUserInfo(dbName, priority, {
+      url: dbProfileUrl,
+      key: dbProfileKey,
+    });
   } else {
-    await UserConfigWrapperActions.setUserInfo(
-      dbName,
-      ourConvo.get('priority') || CONVERSATION_PRIORITIES.default,
-      null
-    );
+    await UserConfigWrapperActions.setUserInfo(dbName, priority, null);
   }
 }
 

ts/types/sqlSharedTypes.ts

@@ -172,7 +172,7 @@ export function getCommunityInfoFromDBValues({
 }) {
   const community = {
     fullUrl,
-    priority,
+    priority: priority || 0,
   };
 
   return community;

ts/util/releaseFeature.ts

@@ -1,4 +1,5 @@
 import { GetNetworkTime } from '../session/apis/snode_api/getNetworkTime';
+import { ConfigurationSync } from '../session/utils/job_runners/jobs/ConfigurationSyncJob';
 import { assertUnreachable } from '../types/sqlSharedTypes';
 import { Storage } from './storage';
 
@@ -46,7 +47,7 @@ function getFeatureReleaseTimestamp(featureName: FeatureNameTracked) {
     //   return 1677488400000; // testing:  unix 27/02/2023 09:00
     case 'user_config_libsession':
       // TODO update to agreed value between platforms for `user_config_libsession`
-
+      // FIXME once we are done with testing the user config over libsession feature
       return (window as any).user_config_libsession || 1706778000000; // unix 01/02/2024 09:00;
     //   return 1677488400000; // testing: unix 27/02/2023 09:00
 
@@ -81,6 +82,8 @@ async function checkIsFeatureReleased(featureName: FeatureNameTracked): Promise<
     window.log.info(`[releaseFeature]: It is time to release ${featureName}. Releasing it now`);
     await Storage.put(`featureReleased-${featureName}`, true);
     setIsFeatureReleasedCached(featureName, true);
+    // trigger a sync right away so our user data is online
+    await ConfigurationSync.queueNewJobIfNeeded();
   }
 
   const isReleased = Boolean(getIsFeatureReleasedCached(featureName));

ts/webworker/workers/browser/libsession_worker_interface.ts

@@ -256,6 +256,11 @@ export const ConvoInfoVolatileWrapperActions: ConvoInfoVolatileWrapperActionsCal
       unread,
     ]) as Promise<ReturnType<ConvoInfoVolatileWrapperActionsCalls['set1o1']>>,
 
+  erase1o1: async (pubkeyHex: string) =>
+    callLibSessionWorker(['ConvoInfoVolatileConfig', 'erase1o1', pubkeyHex]) as Promise<
+      ReturnType<ConvoInfoVolatileWrapperActionsCalls['erase1o1']>
+    >,
+
   // legacy groups
   getLegacyGroup: async (pubkeyHex: string) =>
     callLibSessionWorker(['ConvoInfoVolatileConfig', 'getLegacyGroup', pubkeyHex]) as Promise<

yarn.lock

@@ -5148,9 +5148,9 @@ levn@~0.3.0:
     prelude-ls "~1.1.2"
     type-check "~0.3.2"
 
-"libsession_util_nodejs@https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.14/libsession_util_nodejs-v0.1.14.tar.gz":
-  version "0.1.14"
-  resolved "https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.14/libsession_util_nodejs-v0.1.14.tar.gz#effb7e83ad6f09fb236b3f25497306b0236732ef"
+"libsession_util_nodejs@https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.15/libsession_util_nodejs-v0.1.15.tar.gz":
+  version "0.1.15"
+  resolved "https://github.com/oxen-io/libsession-util-nodejs/releases/download/v0.1.15/libsession_util_nodejs-v0.1.15.tar.gz#276b878bbd68261009dd1081b97e25ee6769fd62"
   dependencies:
     cmake-js "^7.2.1"
     node-addon-api "^6.1.0"