From bbd16dbb54f9b19e118037b759b92fcf57a0f545 Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Tue, 28 Jul 2020 15:12:34 +1000 Subject: [PATCH 1/2] fix size of dialog lightbox with big pictures --- ts/components/Lightbox.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ts/components/Lightbox.tsx b/ts/components/Lightbox.tsx index 1f46fac2b..ad7ce8ac2 100644 --- a/ts/components/Lightbox.tsx +++ b/ts/components/Lightbox.tsx @@ -56,6 +56,9 @@ const styles = { paddingLeft: 40, paddingRight: 40, paddingBottom: 0, + minHeight: 0, + overflow: 'hidden', + minWidth: 0, } as React.CSSProperties, objectContainer: { position: 'relative', From 9354c53490b20bbc7264e76a6de65bcf0607f40f Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Tue, 28 Jul 2020 16:35:44 +1000 Subject: [PATCH 2/2] drop errors when not being able to delete the tmpDir --- test/app/logging_test.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/app/logging_test.js b/test/app/logging_test.js index 82f6cd723..bfdf20fac 100644 --- a/test/app/logging_test.js +++ b/test/app/logging_test.js @@ -28,7 +28,12 @@ describe('app/logging', () => { afterEach(done => { // we need the unsafe option to recursively remove the directory - tmpDir.removeCallback(done); + try { + tmpDir.removeCallback(done); + } catch (e) { + // eslint-disable-next-line no-console + console.error('removeCallback failed with ', e); + } }); describe('#isLineAfterDate', () => {