From 49fcb50d483af8bb716a0b676569daf3e3ca31d6 Mon Sep 17 00:00:00 2001
From: Beaudan Brown <beau@loki.network>
Date: Wed, 23 Oct 2019 13:41:07 +1100
Subject: [PATCH] Update link preview settings to be cleaner
---
_locales/en/messages.json | 9 ++-------
js/views/settings_view.js | 1 -
settings.html | 12 ++++--------
3 files changed, 6 insertions(+), 16 deletions(-)
diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 81a15ee2c..ebfe68fab 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -1227,14 +1227,9 @@
"description":
"Option to control creation and send of link previews in setting screen"
},
- "linkPreviewsDescription": {
- "message":
- "Previews are supported for Imgur, Instagram, Reddit, and YouTube links.",
- "description":
- "Additional detail provided for Link Previews option in settings screen"
- },
"linkPreviewsSettingDescription": {
- "message": "Enable local link previews",
+ "message":
+ "Enable link previews",
"description": "Description shown for the Link Preview option "
},
"spellCheckDescription": {
diff --git a/js/views/settings_view.js b/js/views/settings_view.js
index e30e14d3c..f1d254196 100644
--- a/js/views/settings_view.js
+++ b/js/views/settings_view.js
@@ -250,7 +250,6 @@
spellCheckDescription: i18n('spellCheckDescription'),
blockedHeader: 'Blocked Users',
linkPreviews: i18n('linkPreviews'),
- linkPreviewsDescription: i18n('linkPreviewsDescription'),
linkPreviewsSettingDescription: i18n('linkPreviewsSettingDescription'),
};
},
diff --git a/settings.html b/settings.html
index 0d573e162..bd10df867 100644
--- a/settings.html
+++ b/settings.html
@@ -100,15 +100,11 @@
<input type='checkbox' name='spell-check-setting' id='spell-check-setting' />
<label for='spell-check-setting'>{{ spellCheckDescription }}</label>
</div>
+ <div class='link-preview-setting'>
+ <input type='checkbox' name='link-preview-setting' id='link-preview-setting' />
+ <label for='link-preview-setting'>{{ linkPreviewsSettingDescription }}</label>
+ </div>
- <hr>
- <h3>{{ linkPreviews }}</h3>
- <div>{{ linkPreviewsDescription }}<div>
- </br>
- <div class='link-preview-setting'>
- <input type='checkbox' name='link-preview-setting' id='link-preview-setting' />
- <label for='link-preview-setting'>{{ linkPreviewsSettingDescription }}</label>
- </div>
<hr>
<div class='permissions-setting'>
<h3>{{ permissions }}</h3>