From 471443e33bb074a9fbaa9230d5c2710a938b5aab Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Fri, 20 Jul 2018 14:52:52 -0700 Subject: [PATCH] Streamline code to clean logs based on version number --- js/background.js | 5 ++++- preload.js | 13 +++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/js/background.js b/js/background.js index f485fd3ee..518737fe2 100644 --- a/js/background.js +++ b/js/background.js @@ -234,7 +234,10 @@ await storage.put('version', currentVersion); if (newVersion) { - if (currentVersion === '1.14.2' || currentVersion === '1.15.0-beta.2') { + if ( + lastVersion && + window.isBeforeVersion(lastVersion, 'v1.15.0-beta.4') + ) { await window.Signal.Logs.deleteAll(); window.restart(); } diff --git a/preload.js b/preload.js index e51174b47..7761b09a8 100644 --- a/preload.js +++ b/preload.js @@ -4,6 +4,7 @@ console.log('preload'); const electron = require('electron'); +const semver = require('semver'); const { deferredToPromise } = require('./js/modules/deferred_to_promise'); @@ -29,6 +30,18 @@ window.getExpiration = () => config.buildExpiration; window.getNodeVersion = () => config.node_version; window.getHostName = () => config.hostname; +window.isBeforeVersion = (toCheck, baseVersion) => { + try { + return semver.lt(toCheck, baseVersion); + } catch (error) { + console.log( + `isBeforeVersion error: toCheck: ${toCheck}, baseVersion: ${baseVersion}`, + error && error.stack ? error.stack : error + ); + return true; + } +}; + window.wrapDeferred = deferredToPromise; const ipc = electron.ipcRenderer;