From c08f761d47f50423f1309196ebe8c9647a1c5882 Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Wed, 10 Aug 2022 14:02:35 +1000 Subject: [PATCH] fix: revert to allow 3 attachments download at a time --- ts/session/utils/AttachmentsDownload.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ts/session/utils/AttachmentsDownload.ts b/ts/session/utils/AttachmentsDownload.ts index b4f85aade..be2539353 100644 --- a/ts/session/utils/AttachmentsDownload.ts +++ b/ts/session/utils/AttachmentsDownload.ts @@ -10,7 +10,7 @@ import { initializeAttachmentLogic, processNewAttachment } from '../../types/Mes import { getAttachmentMetadata } from '../../types/message/initializeAttachmentMetadata'; // this cause issues if we increment that value to > 1. -const MAX_ATTACHMENT_JOB_PARALLELISM = 1; +const MAX_ATTACHMENT_JOB_PARALLELISM = 3; const TICK_INTERVAL = Constants.DURATION.MINUTES; // tslint:disable: function-name @@ -231,7 +231,11 @@ async function _runJob(job: any) { ); found = await Data.getMessageById(messageId); - _addAttachmentToMessage(found, _markAttachmentAsError(attachment), { type, index }); + try { + _addAttachmentToMessage(found, _markAttachmentAsError(attachment), { type, index }); + } catch (e) { + // just swallow any exceptions here, as it would be an unhandled one + } await _finishJob(found || null, id); return;