From 442f5d7295761f488b4d396aedf20ab0a2e32fc9 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Fri, 30 Mar 2018 17:20:50 -0400 Subject: [PATCH] Use `done` to match JavaScript iterators See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_Generators --- js/background.js | 2 +- js/modules/messages_data_migrator.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/background.js b/js/background.js index b990cfd8b..8e0c0c51b 100644 --- a/js/background.js +++ b/js/background.js @@ -108,7 +108,7 @@ }); console.log('Upgrade message schema:', results); - if (!results.hasMore) { + if (!results.done) { idleDetector.stop(); } }); diff --git a/js/modules/messages_data_migrator.js b/js/modules/messages_data_migrator.js index 5f7732d53..5545853d8 100644 --- a/js/modules/messages_data_migrator.js +++ b/js/modules/messages_data_migrator.js @@ -70,9 +70,9 @@ exports.processNext = async ({ const totalDuration = Date.now() - startTime; const numProcessed = messagesRequiringSchemaUpgrade.length; - const hasMore = numProcessed > 0; + const done = numProcessed > 0; return { - hasMore, + done, numProcessed, fetchDuration, upgradeDuration,