chore: address PR reviews

pull/3281/head
Audric Ackermann 2 months ago
parent 821a304fa3
commit 3f1adff288
No known key found for this signature in database

@ -132,7 +132,7 @@ function RecreateGroupButton() {
buttonColor={SessionButtonColor.Primary}
margin="var(--margins-sm)"
onClick={() => {
showRecreateGroupModal(name || 'Unknown group name', members);
showRecreateGroupModal(name || localize('groupUnknown').toString(), members);
}}
>
{localize('recreateGroup').toString()}

@ -19,6 +19,7 @@ import { MessageContextMenu } from './MessageContextMenu';
import { MessageReactions } from './MessageReactions';
import { MessageStatus } from './MessageStatus';
import { useIsMessageSelectionMode } from '../../../../state/selectors/selectedConversation';
import { useSelectedDisableLegacyGroupDeprecatedActions } from '../../../../hooks/useRefreshReleasedFeaturesTimestamp';
export type MessageContentWithStatusSelectorProps = { isGroup: boolean } & Pick<
MessageRenderingProps,
@ -62,6 +63,7 @@ export const MessageContentWithStatuses = (props: Props) => {
const hideAvatar = useHideAvatarInMsgList(props.messageId);
const multiSelectMode = useIsMessageSelectionMode();
const legacyGroupActionsDisabled = useSelectedDisableLegacyGroupDeprecatedActions();
const onClickOnMessageOuterContainer = useCallback(
(event: MouseEvent<HTMLDivElement>) => {
@ -75,6 +77,9 @@ export const MessageContentWithStatuses = (props: Props) => {
);
const onDoubleClickReplyToMessage = (e: MouseEvent<HTMLDivElement>) => {
if (legacyGroupActionsDisabled) {
return;
}
const currentSelection = window.getSelection();
const currentSelectionString = currentSelection?.toString() || undefined;

@ -144,6 +144,10 @@ export const OverlayClosedGroupV2 = () => {
dispatch(resetLeftOverlayMode());
}
function onValueChanged(value: string) {
dispatch(groupInfoActions.updateGroupCreationName({ name: value }));
}
async function onEnterPressed() {
setGroupNameError(undefined);
if (isCreatingGroup) {
@ -209,9 +213,7 @@ export const OverlayClosedGroupV2 = () => {
type="text"
placeholder={window.i18n('groupNameEnter')}
value={groupName}
onValueChanged={value => {
dispatch(groupInfoActions.updateGroupCreationName({ name: value }));
}}
onValueChanged={onValueChanged}
onEnterPressed={onEnterPressed}
error={groupNameError}
maxLength={LIBSESSION_CONSTANTS.BASE_GROUP_MAX_NAME_LENGTH}

@ -1273,8 +1273,7 @@ const metaGroupSlice = createSlice({
if (state.creationMembersSelected.includes(payload.memberToAdd)) {
return state;
}
const together = state.creationMembersSelected.concat(payload.memberToAdd);
state.creationMembersSelected = uniq(together);
state.creationMembersSelected.push(payload.memberToAdd);
return state;
},

Loading…
Cancel
Save