From 3acdeb90c3b61d1026789ef489e98b8adcd34b8b Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Sat, 14 Apr 2018 23:27:38 -0400 Subject: [PATCH] Make `ReactWrapperView` globals explicit --- js/views/react_wrapper_view.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/js/views/react_wrapper_view.js b/js/views/react_wrapper_view.js index ff5768908..501e654b0 100644 --- a/js/views/react_wrapper_view.js +++ b/js/views/react_wrapper_view.js @@ -1,9 +1,7 @@ /* global Backbone: false */ - -// Additional globals used: -// window.React -// window.ReactDOM -// window.i18n +/* global i18n: false */ +/* global React: false */ +/* global ReactDOM: false */ // eslint-disable-next-line func-names (function () { @@ -26,8 +24,8 @@ }, update(props) { const updatedProps = this.augmentProps(props); - const element = window.React.createElement(this.Component, updatedProps); - window.ReactDOM.render(element, this.el); + const reactElement = React.createElement(this.Component, updatedProps); + ReactDOM.render(reactElement, this.el); }, augmentProps(props) { return Object.assign({}, props, { @@ -38,11 +36,11 @@ } this.remove(); }, - i18n: window.i18n, + i18n, }); }, remove() { - window.ReactDOM.unmountComponentAtNode(this.el); + ReactDOM.unmountComponentAtNode(this.el); Backbone.View.prototype.remove.call(this); }, });