From e78426de99e539842596881c86b3f5ce319250bf Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Wed, 1 Apr 2020 21:13:48 -0700 Subject: [PATCH 1/3] just in case onChange isnt triggered --- ts/components/session/SessionInput.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ts/components/session/SessionInput.tsx b/ts/components/session/SessionInput.tsx index 11432e80a..edd8c64ed 100644 --- a/ts/components/session/SessionInput.tsx +++ b/ts/components/session/SessionInput.tsx @@ -61,6 +61,10 @@ export class SessionInput extends React.PureComponent { className={classNames( enableShowHide ? 'session-input-floating-label-show-hide' : '' )} + // just incase onChange isn't triggered + onBlur={e => { + this.updateInputValue(e); + }} onKeyPress={event => { event.persist(); if (event.key === 'Enter' && this.props.onEnterPressed) { From 34a1fdbfec0e216335bed5373870974bff23a5d4 Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Wed, 1 Apr 2020 21:43:07 -0700 Subject: [PATCH 2/3] add onBlur incase onChange doesn't fire --- ts/components/session/SessionIdEditable.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/ts/components/session/SessionIdEditable.tsx b/ts/components/session/SessionIdEditable.tsx index dc4bab8bc..6fca9f63e 100644 --- a/ts/components/session/SessionIdEditable.tsx +++ b/ts/components/session/SessionIdEditable.tsx @@ -45,6 +45,7 @@ export class SessionIdEditable extends React.PureComponent { spellCheck={false} onKeyDown={this.handleKeyDown} onChange={this.handleChange} + onBlur={this.handleChange} value={value || text} maxLength={maxLength} /> From 86ab440bb8832048b72934eb2606792b771cc6ec Mon Sep 17 00:00:00 2001 From: Ryan Tharp Date: Wed, 1 Apr 2020 23:11:15 -0700 Subject: [PATCH 3/3] make minimum window height, so integration tests can clicked on closed group button --- main.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/main.js b/main.js index 66ac9c46f..d398aa1ae 100644 --- a/main.js +++ b/main.js @@ -199,9 +199,11 @@ function captureClicks(window) { } const DEFAULT_WIDTH = 880; -const DEFAULT_HEIGHT = 720; +// add contact button needs to be visible (on HiDpi screens?) +// otherwise integration test fail +const DEFAULT_HEIGHT = 820; const MIN_WIDTH = 880; -const MIN_HEIGHT = 720; +const MIN_HEIGHT = 820; const BOUNDS_BUFFER = 100; function isVisible(window, bounds) {