From 2c3847affee52d4abf54fc1f466d336918f4f342 Mon Sep 17 00:00:00 2001
From: Scott Nonnenberg <scott@signal.org>
Date: Wed, 13 Feb 2019 12:04:45 -0800
Subject: [PATCH] MessageReceiver: Don't wait for cache update to move forward

---
 libtextsecure/message_receiver.js | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/libtextsecure/message_receiver.js b/libtextsecure/message_receiver.js
index a8a7f23ba..4d85ae39e 100644
--- a/libtextsecure/message_receiver.js
+++ b/libtextsecure/message_receiver.js
@@ -801,19 +801,18 @@ MessageReceiver.prototype.extend({
       .then(plaintext => {
         const { isMe, isBlocked } = plaintext || {};
         if (isMe || isBlocked) {
-          return this.removeFromCache(envelope);
+          this.removeFromCache(envelope);
+          return null;
         }
 
-        return this.updateCache(envelope, plaintext).then(
-          () => plaintext,
-          error => {
-            window.log.error(
-              'decrypt failed to save decrypted message contents to cache:',
-              error && error.stack ? error.stack : error
-            );
-            return plaintext;
-          }
-        );
+        this.updateCache(envelope, plaintext).catch(error => {
+          window.log.error(
+            'decrypt failed to save decrypted message contents to cache:',
+            error && error.stack ? error.stack : error
+          );
+        });
+
+        return plaintext;
       })
       .catch(error => {
         let errorToThrow = error;