Update issue and pull request templates
Issue template - more explanations and tips - clarify how to fill checkboxes - actual and expected results - remove link to the community forum PR template - clarify how to fill checkboxes - more about tests - add a link to an explanation for BitHub rewards - explain that failing Travis CI build checks are normal Closes #735 // FREEBIEpull/749/head
parent
c8d03d9019
commit
27dc620566
@ -1,20 +1,28 @@
|
||||
<!-- You can remove this section if you have contributed before -->
|
||||
<!-- You can remove this first section if you have contributed before -->
|
||||
### First time contributor checklist
|
||||
<!-- mark with x between the brackets -->
|
||||
- [ ] I have read the [Contributor Guidelines](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md)
|
||||
<!-- replace the empty checkboxes [ ] below with checked ones [x] accordingly -->
|
||||
- [ ] I have read the [README](https://github.com/WhisperSystems/Signal-Desktop/blob/master/README.md) and [Contributor Guidelines](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md)
|
||||
- [ ] I have signed the [Contributor Licence Agreement](https://whispersystems.org/cla/)
|
||||
|
||||
### Contributor checklist
|
||||
<!-- mark with x between the brackets -->
|
||||
<!-- replace the empty checkboxes [ ] below with checked ones [x] accordingly -->
|
||||
- [ ] My contribution is fully baked and ready to be merged as is
|
||||
- [ ] My changes are rebased on the latest master branch
|
||||
- [ ] My contribution is fully baked and is ready to be merged as is
|
||||
- [ ] I have run the tests on these platforms:
|
||||
- [ ] My commits are in nice logical chunks
|
||||
- [ ] I have followed the [best practices](http://chris.beams.io/posts/git-commit/) in my commit messages
|
||||
- [ ] I have made the choice whether I want the [BitHub reward](https://github.com/WhisperSystems/Signal-Android/wiki/BitHub-Rewards) or not by omitting or adding the word `FREEBIE` in my Git commit messages
|
||||
- [ ] I have tested my contribution on these platforms:
|
||||
* GNU Hurd 1.0, Chrom{e,ium} X.Y.Z
|
||||
* Amiga OS 3.1, Chrom{e,ium} Z.Y
|
||||
- [ ] My commits are in nice logical chunks
|
||||
- [ ] I followed the [best practices](http://chris.beams.io/posts/git-commit/) when writing my commit messages
|
||||
- [ ] I have made the choice whether I want the Bithub reward or not by omitting or adding the word `FREEBIE` in my commit message
|
||||
- [ ] My changes pass all the [local tests](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md#tests) 100%
|
||||
- [ ] I have considered whether my changes need additional [tests](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md#tests), and in the case they do, I have written them
|
||||
|
||||
----------
|
||||
----------------------------------------
|
||||
|
||||
### Description
|
||||
<!--
|
||||
Describe briefly what your pull request proposes to fix. Especially if you have more than one commit, it is helpful to give a summary of what your contribution as a whole is trying to solve.
|
||||
Also, please describe shortly how you tested that your fix actually works.
|
||||
|
||||
Please note, that after you have submitted your PR, the Travis CI build check will fail. This is a known issue (#708) and you don't have to worry about it. (■_■¬)
|
||||
-->
|
||||
|
Loading…
Reference in New Issue