Let textsecure devices throw on identity key change

Restore error format, accidentally removed in 43d6efcd

// FREEBIE

js/libtextsecure.js

@@ -38109,15 +38109,23 @@ axolotlInternal.RecipientRecord = function() {
     window.textsecure.storage.devices = {
         saveKeysToDeviceObject: function(deviceObject) {
             var number = textsecure.utils.unencodeNumber(deviceObject.encodedNumber)[0];
-            return textsecure.storage.axolotl.putIdentityKey(number, deviceObject.identityKey).then(function() {
-                tempKeys[deviceObject.encodedNumber] = {
-                    preKey:  deviceObject.preKey,
-                    preKeyId: deviceObject.preKeyId,
-                    signedKey: deviceObject.signedKey,
-                    signedKeyId: deviceObject.signedKeyId,
-                    signedKeySignature: deviceObject.signedKeySignature,
-                    registrationId: deviceObject.registrationId
-                };
+            return textsecure.storage.axolotl.getIdentityKey(number).then(function(identityKey) {
+                if (identityKey !== undefined && deviceObject.identityKey !== undefined && getString(identityKey) != getString(deviceObject.identityKey)) {
+                    var error = new Error("Identity key changed");
+                    error.identityKey = deviceObject.identityKey;
+                    throw error;
+                }
+
+                return textsecure.storage.axolotl.putIdentityKey(number, deviceObject.identityKey).then(function() {
+                    tempKeys[deviceObject.encodedNumber] = {
+                        preKey:  deviceObject.preKey,
+                        preKeyId: deviceObject.preKeyId,
+                        signedKey: deviceObject.signedKey,
+                        signedKeyId: deviceObject.signedKeyId,
+                        signedKeySignature: deviceObject.signedKeySignature,
+                        registrationId: deviceObject.registrationId
+                    };
+                });
             });
         },
 

libtextsecure/storage/devices.js

@@ -28,15 +28,23 @@
     window.textsecure.storage.devices = {
         saveKeysToDeviceObject: function(deviceObject) {
             var number = textsecure.utils.unencodeNumber(deviceObject.encodedNumber)[0];
-            return textsecure.storage.axolotl.putIdentityKey(number, deviceObject.identityKey).then(function() {
-                tempKeys[deviceObject.encodedNumber] = {
-                    preKey:  deviceObject.preKey,
-                    preKeyId: deviceObject.preKeyId,
-                    signedKey: deviceObject.signedKey,
-                    signedKeyId: deviceObject.signedKeyId,
-                    signedKeySignature: deviceObject.signedKeySignature,
-                    registrationId: deviceObject.registrationId
-                };
+            return textsecure.storage.axolotl.getIdentityKey(number).then(function(identityKey) {
+                if (identityKey !== undefined && deviceObject.identityKey !== undefined && getString(identityKey) != getString(deviceObject.identityKey)) {
+                    var error = new Error("Identity key changed");
+                    error.identityKey = deviceObject.identityKey;
+                    throw error;
+                }
+
+                return textsecure.storage.axolotl.putIdentityKey(number, deviceObject.identityKey).then(function() {
+                    tempKeys[deviceObject.encodedNumber] = {
+                        preKey:  deviceObject.preKey,
+                        preKeyId: deviceObject.preKeyId,
+                        signedKey: deviceObject.signedKey,
+                        signedKeyId: deviceObject.signedKeyId,
+                        signedKeySignature: deviceObject.signedKeySignature,
+                        registrationId: deviceObject.registrationId
+                    };
+                });
             });
         },