disable menubar by default and remove old preferences from menubar

app/menu.js

@@ -16,17 +16,12 @@ exports.createTemplate = (options, messages) => {
     setupWithImport,
     showAbout,
     showDebugLog,
-    showSettings,
   } = options;
 
   const template = [
     {
       label: messages.mainMenuFile.message,
       submenu: [
-        {
-          label: messages.mainMenuSettings.message,
-          click: showSettings,
-        },
         {
           type: 'separator',
         },
@@ -193,7 +188,6 @@ function updateForMac(template, messages, options) {
     setupAsStandalone,
     setupWithImport,
     showAbout,
-    showSettings,
     showWindow,
   } = options;
 
@@ -242,11 +236,6 @@ function updateForMac(template, messages, options) {
       {
         type: 'separator',
       },
-      {
-        label: messages.mainMenuSettings.message,
-        accelerator: 'CommandOrControl+,',
-        click: showSettings,
-      },
       {
         type: 'separator',
       },

js/background.js

@@ -1005,8 +1005,13 @@
     };
 
     window.toggleMenuBar = () => {
-      const newValue = !window.getSettingValue('hide-menu-bar');
-      window.Events.setHideMenuBar(newValue);
+      const current = window.getSettingValue('hide-menu-bar');
+      if (current === undefined) {
+        window.Events.setHideMenuBar(false);
+        return;
+      }
+
+      window.Events.setHideMenuBar(!current);
     };
 
     window.toggleSpellCheck = () => {

js/views/app_view.js

@@ -38,7 +38,7 @@
       }
     },
     applyHideMenu() {
-      const hideMenuBar = storage.get('hide-menu-bar', false);
+      const hideMenuBar = storage.get('hide-menu-bar', true);
       window.setAutoHideMenuBar(hideMenuBar);
       window.setMenuBarVisibility(!hideMenuBar);
     },

ts/components/session/settings/SessionSettings.tsx

@@ -314,7 +314,7 @@ export class SettingsView extends React.Component<SettingsViewProps, State> {
         type: SessionSettingType.Toggle,
         category: SessionSettingCategory.General,
         setFn: window.toggleMenuBar,
-        content: undefined,
+        content: { defaultValue: true },
         comparisonValue: undefined,
         onClick: undefined,
       },