From 21586f8e1491dab144d55448a01c75cbf007eb45 Mon Sep 17 00:00:00 2001 From: Mikunj Date: Fri, 22 May 2020 16:06:31 +1000 Subject: [PATCH] Linting + Improve tslint rules in tests --- ts/test/session/utils/JobQueue_test.ts | 7 +++++-- ts/test/tslint.json | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ts/test/session/utils/JobQueue_test.ts b/ts/test/session/utils/JobQueue_test.ts index b3f4a5c18..864c69247 100644 --- a/ts/test/session/utils/JobQueue_test.ts +++ b/ts/test/session/utils/JobQueue_test.ts @@ -2,7 +2,6 @@ import chai from 'chai'; import { v4 as uuid } from 'uuid'; import { JobQueue } from '../../../session/utils/JobQueue'; import { timeout } from '../../utils/timeout'; -import { SignalService } from '../../../protobuf'; // tslint:disable-next-line: no-require-imports no-var-requires const chaiAsPromised = require('chai-as-promised'); @@ -36,7 +35,11 @@ describe('JobQueue', () => { }); const start = Date.now(); - await assert.eventually.deepEqual(Promise.all(input.map(mapper)), [10, 20, 30]); + await assert.eventually.deepEqual(Promise.all(input.map(mapper)), [ + 10, + 20, + 30, + ]); const timeTaken = Date.now() - start; assert.closeTo(timeTaken, 600, 50, 'Queue was delayed'); }); diff --git a/ts/test/tslint.json b/ts/test/tslint.json index 21571a6db..9d1d3e71b 100644 --- a/ts/test/tslint.json +++ b/ts/test/tslint.json @@ -10,6 +10,7 @@ "no-unused-expression": false, - "await-promise": [true, "PromiseLike"] + "await-promise": [true, "PromiseLike"], + "no-floating-promises": [true, "PromiseLike"] } }