From 204de3aaea0f52e0fdb9e49d09ed96ad7c211dc6 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Sun, 15 Apr 2018 02:52:33 -0400 Subject: [PATCH] Lazily bind `Signal.Components.MediaGallery` --- js/views/conversation_view.js | 33 +-------------------------------- 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/js/views/conversation_view.js b/js/views/conversation_view.js index d235f4ed6..cce923c51 100644 --- a/js/views/conversation_view.js +++ b/js/views/conversation_view.js @@ -16,8 +16,6 @@ window.Whisper = window.Whisper || {}; - const { MediaGallery } = window.Signal.Components; - Whisper.ExpiredToast = Whisper.ToastView.extend({ render_attributes() { return { toastMessage: i18n('expiredWarning') }; @@ -610,7 +608,7 @@ }; const view = new Whisper.ReactWrapperView({ - Component: MediaGallery, + Component: Signal.Components.MediaGallery, props: mediaGalleryProps, onClose: () => this.resetPanel(), }); @@ -675,35 +673,6 @@ } }, - viewAllMedia() { - // We have to do this manually, since our React component will not propagate click - // events up to its parent elements in the DOM. - this.closeMenu(); - - // Next: - // pull latest media - // need a way for react component to request further data - - // needed components: - // GalleryPanel - // Section - header, list of thumbnails - // Thumbnail - // Lightbox - or do we use the lightbox already in the app? - - const props = { - media: [], - documents: [], - }; - - const view = new window.Whisper.ReactWrapper({ - Component: MediaGallery, - props, - onClose: () => this.resetPanel(), - }); - - this.listenBack(view); - }, - focusMessageField() { this.$messageField.focus(); },