From 1e2cd3ae1fd2ec330392b945e67d48ccd475a849 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Mon, 5 Mar 2018 18:36:25 -0500 Subject: [PATCH] =?UTF-8?q?Rename=20=E2=80=98File=20a=20Bug=E2=80=99=20to?= =?UTF-8?q?=20=E2=80=98Report=20an=20Issue=E2=80=99?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes it more consistent with ‘Report an issue’ under View > Debug Log. Not using ellipsis as menu item doesn’t require user confirmation: https://stackoverflow.com/a/637708 --- _locales/en/messages.json | 6 +++--- app/menu.js | 2 +- test/app/fixtures/menu-mac-os-setup.json | 2 +- test/app/fixtures/menu-mac-os.json | 2 +- test/app/fixtures/menu-windows-linux-setup.json | 2 +- test/app/fixtures/menu-windows-linux.json | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/_locales/en/messages.json b/_locales/en/messages.json index e5fe9f1e1..101522c33 100644 --- a/_locales/en/messages.json +++ b/_locales/en/messages.json @@ -386,9 +386,9 @@ "message": "Go to Support Page", "description": "Item under the Help menu, takes you to the support page" }, - "fileABug": { - "message": "File a Bug", - "description": "Item under the Help menu, takes you to GitHub new issue form" + "menuReportIssue": { + "message": "Report an Issue", + "description": "Item under the Help menu, takes you to GitHub new issue form (title case)" }, "aboutSignalDesktop": { "message": "About Signal Desktop", diff --git a/app/menu.js b/app/menu.js index 878a6ec1a..16c0fe23f 100644 --- a/app/menu.js +++ b/app/menu.js @@ -130,7 +130,7 @@ exports.createTemplate = (options, messages) => { click: openSupportPage, }, { - label: messages.fileABug.message, + label: messages.menuReportIssue.message, click: openNewBugForm, }, { diff --git a/test/app/fixtures/menu-mac-os-setup.json b/test/app/fixtures/menu-mac-os-setup.json index b68a81bbb..c044898a0 100644 --- a/test/app/fixtures/menu-mac-os-setup.json +++ b/test/app/fixtures/menu-mac-os-setup.json @@ -172,7 +172,7 @@ "click": null }, { - "label": "File a Bug", + "label": "Report an Issue", "click": null } ] diff --git a/test/app/fixtures/menu-mac-os.json b/test/app/fixtures/menu-mac-os.json index a0d79f593..2a4d73d5c 100644 --- a/test/app/fixtures/menu-mac-os.json +++ b/test/app/fixtures/menu-mac-os.json @@ -159,7 +159,7 @@ "click": null }, { - "label": "File a Bug", + "label": "Report an Issue", "click": null } ] diff --git a/test/app/fixtures/menu-windows-linux-setup.json b/test/app/fixtures/menu-windows-linux-setup.json index 57deb232d..570bebbd9 100644 --- a/test/app/fixtures/menu-windows-linux-setup.json +++ b/test/app/fixtures/menu-windows-linux-setup.json @@ -119,7 +119,7 @@ "click": null }, { - "label": "File a Bug", + "label": "Report an Issue", "click": null }, { diff --git a/test/app/fixtures/menu-windows-linux.json b/test/app/fixtures/menu-windows-linux.json index 07927245e..4185cf586 100644 --- a/test/app/fixtures/menu-windows-linux.json +++ b/test/app/fixtures/menu-windows-linux.json @@ -108,7 +108,7 @@ "click": null }, { - "label": "File a Bug", + "label": "Report an Issue", "click": null }, {