Merge pull request #3130 from Bilb/feat/hit-less-often-fileserver
feat: hit only once every 30mins the fs for releasepull/2794/merge
Audric Ackermann
8 months ago
committed by
GitHub
commit
15a3c8bc38
@ -0,0 +1,15 @@
|
||||
import { useSelector } from 'react-redux';
|
||||
import useInterval from 'react-use/lib/useInterval';
|
||||
import { getOurPrimaryConversation } from '../state/selectors/conversations';
|
||||
import { fetchLatestRelease } from '../session/fetch_latest_release';
|
||||
|
||||
export function useFetchLatestReleaseFromFileServer() {
|
||||
const ourPrimaryConversation = useSelector(getOurPrimaryConversation);
|
||||
|
||||
useInterval(() => {
|
||||
if (!ourPrimaryConversation) {
|
||||
return;
|
||||
}
|
||||
void fetchLatestRelease.fetchReleaseFromFSAndUpdateMain();
|
||||
}, fetchLatestRelease.fetchReleaseFromFileServerInterval);
|
||||
}
|
||||
@ -0,0 +1,55 @@
|
||||
// every 1 minute we fetch from the fileserver to check for a new release
|
||||
// * if there is none, no request to github are made.
|
||||
// * if there is a version on the fileserver more recent than our current, we fetch github to get the UpdateInfos and trigger an update as usual (asking user via dialog)
|
||||
|
||||
import { isEmpty, isString } from 'lodash';
|
||||
import { ipcRenderer } from 'electron';
|
||||
import { DURATION } from '../constants';
|
||||
import { getLatestReleaseFromFileServer } from '../apis/file_server_api/FileServerApi';
|
||||
|
||||
/**
|
||||
* Try to fetch the latest release from the fileserver every 1 minute.
|
||||
* If we did fetch a release already in the last 30 minutes, we will skip the call.
|
||||
*/
|
||||
const fetchReleaseFromFileServerInterval = DURATION.MINUTES * 1;
|
||||
|
||||
/**
|
||||
* We don't want to hit the fileserver too often. Only often on start, and then every 30 minutes
|
||||
*/
|
||||
const skipIfLessThan = DURATION.MINUTES * 30;
|
||||
|
||||
let lastFetchedTimestamp = Number.MIN_SAFE_INTEGER;
|
||||
|
||||
function resetForTesting() {
|
||||
lastFetchedTimestamp = Number.MIN_SAFE_INTEGER;
|
||||
}
|
||||
|
||||
async function fetchReleaseFromFSAndUpdateMain() {
|
||||
try {
|
||||
window.log.info('[updater] about to fetchReleaseFromFSAndUpdateMain');
|
||||
const diff = Date.now() - lastFetchedTimestamp;
|
||||
if (diff < skipIfLessThan) {
|
||||
window.log.info(
|
||||
`[updater] fetched release from fs ${Math.floor(diff / DURATION.MINUTES)}minutes ago, skipping until that's at least ${Math.floor(skipIfLessThan / DURATION.MINUTES)}`
|
||||
);
|
||||
return;
|
||||
}
|
||||
|
||||
const justFetched = await getLatestReleaseFromFileServer();
|
||||
window.log.info('[updater] fetched latest release from fileserver: ', justFetched);
|
||||
|
||||
if (isString(justFetched) && !isEmpty(justFetched)) {
|
||||
lastFetchedTimestamp = Date.now();
|
||||
ipcRenderer.send('set-release-from-file-server', justFetched);
|
||||
window.readyForUpdates();
|
||||
}
|
||||
} catch (e) {
|
||||
window.log.warn(e);
|
||||
}
|
||||
}
|
||||
|
||||
export const fetchLatestRelease = {
|
||||
fetchReleaseFromFileServerInterval,
|
||||
fetchReleaseFromFSAndUpdateMain,
|
||||
resetForTesting,
|
||||
};
|
||||
Loading…
Reference in New Issue