Merge pull request #3025 from Bilb/fix-make-dialog-click-close-required

fix: make onClickClose on confirmModal mandatory

ts/components/dialog/SessionConfirm.tsx

@@ -49,7 +49,7 @@ export interface SessionConfirmDialogProps {
    */
   onClickOk?: (...args: Array<any>) => Promise<void> | void;
 
-  onClickClose?: () => any;
+  onClickClose: () => any;
 
   /**
    * function to run on close click. Closes modal after execution by default

ts/components/leftpane/overlay/OverlayMessageRequest.tsx

@@ -87,6 +87,9 @@ export const OverlayMessageRequest = () => {
 
           await forceSyncConfigurationNowIfNeeded();
         },
+        onClickClose: () => {
+          window.inboxStore?.dispatch(updateConfirmModal(null));
+        },
       })
     );
   }

ts/components/settings/section/CategoryPermissions.tsx

@@ -27,6 +27,9 @@ const toggleCallMediaPermissions = async (triggerUIUpdate: () => void) => {
           await window.toggleCallMediaPermissionsTo(false);
           triggerUIUpdate();
         },
+        onClickClose: () => {
+          window.inboxStore?.dispatch(updateConfirmModal(null));
+        },
       })
     );
   } else {

ts/interactions/conversations/unsendingInteractions.ts

@@ -364,6 +364,7 @@ export async function deleteMessagesByIdForEveryone(
         closeDialog();
       },
       onClickCancel: closeDialog,
+      onClickClose: closeDialog,
       closeAfterInput: false,
     })
   );