From 135b9cf34dd4fad6001a89aa9c424544a473b061 Mon Sep 17 00:00:00 2001
From: Audric Ackermann <audric@loki.network>
Date: Fri, 7 Oct 2022 12:22:15 +1100
Subject: [PATCH] fix: add toast on rate limit hit for reactions

---
 _locales/en/messages.json                             |  1 +
 .../apis/open_group_api/sogsv3/sogsV3SendReaction.ts  |  4 +++-
 ts/session/utils/Toast.tsx                            |  4 ++++
 ts/types/LocalizerKeys.ts                             |  1 +
 ts/util/reactions.ts                                  | 11 ++++++-----
 5 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 100ea14de..6d7c6ea1a 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -484,6 +484,7 @@
   "clearAllReactions": "Are you sure you want to clear all $emoji$ ?",
   "expandedReactionsText": "Show Less",
   "reactionNotification": "Reacts to a message with $emoji$",
+  "rateLimitReactMessage": "Slow down! You've sent too many emoji reacts. Try again soon",
   "otherSingular": "$number$ other",
   "otherPlural": "$number$ others",
   "reactionPopup": "reacted with",
diff --git a/ts/session/apis/open_group_api/sogsv3/sogsV3SendReaction.ts b/ts/session/apis/open_group_api/sogsv3/sogsV3SendReaction.ts
index 445219e40..5a112dca3 100644
--- a/ts/session/apis/open_group_api/sogsv3/sogsV3SendReaction.ts
+++ b/ts/session/apis/open_group_api/sogsv3/sogsV3SendReaction.ts
@@ -5,7 +5,7 @@ import { Action, OpenGroupReactionResponse, Reaction } from '../../../../types/R
 import { getEmojiDataFromNative } from '../../../../util/emoji';
 import { Reactions } from '../../../../util/reactions';
 import { OnionSending } from '../../../onions/onionSend';
-import { UserUtils } from '../../../utils';
+import { ToastUtils, UserUtils } from '../../../utils';
 import { OpenGroupPollingUtils } from '../opengroupV2/OpenGroupPollingUtils';
 import { getUsBlindedInThatServer } from './knownBlindedkeys';
 import { batchGlobalIsSuccess, parseBatchGlobalStatusCode } from './sogsV3BatchPoll';
@@ -58,6 +58,8 @@ export const sendSogsReactionOnionV4 = async (
   }
 
   if (Reactions.hitRateLimit()) {
+    ToastUtils.pushRateLimitHitReactions();
+
     return false;
   }
 
diff --git a/ts/session/utils/Toast.tsx b/ts/session/utils/Toast.tsx
index 54a1ba80f..4170dc64d 100644
--- a/ts/session/utils/Toast.tsx
+++ b/ts/session/utils/Toast.tsx
@@ -277,3 +277,7 @@ export function pushNoMediaUntilApproved() {
 export function pushMustBeApproved() {
   pushToastError('mustBeApproved', window.i18n('mustBeApproved'));
 }
+
+export function pushRateLimitHitReactions() {
+  pushToastInfo('reactRateLimit', '', window?.i18n?.('rateLimitReactMessage')); // because otherwise test fails
+}
diff --git a/ts/types/LocalizerKeys.ts b/ts/types/LocalizerKeys.ts
index 95a12580f..f23f5fb23 100644
--- a/ts/types/LocalizerKeys.ts
+++ b/ts/types/LocalizerKeys.ts
@@ -87,6 +87,7 @@ export type LocalizerKeys =
   | 'enterNewPassword'
   | 'expandedReactionsText'
   | 'openMessageRequestInbox'
+  | 'rateLimitReactMessage'
   | 'enterPassword'
   | 'enterSessionIDOfRecipient'
   | 'join'
diff --git a/ts/util/reactions.ts b/ts/util/reactions.ts
index 3193ba5d3..0659c5224 100644
--- a/ts/util/reactions.ts
+++ b/ts/util/reactions.ts
@@ -6,7 +6,7 @@ import {
   getUsBlindedInThatServer,
   isUsAnySogsFromCache,
 } from '../session/apis/open_group_api/sogsv3/knownBlindedkeys';
-import { UserUtils } from '../session/utils';
+import { ToastUtils, UserUtils } from '../session/utils';
 
 import { Action, OpenGroupReactionList, ReactionList, RecentReactions } from '../types/Reaction';
 import { getRecentReactions, saveRecentReations } from '../util/storage';
@@ -17,14 +17,14 @@ const rateTimeLimit = 60 * 1000;
 const latestReactionTimestamps: Array<number> = [];
 
 function hitRateLimit(): boolean {
-  const timestamp = Date.now();
-  latestReactionTimestamps.push(timestamp);
+  const now = Date.now();
+  latestReactionTimestamps.push(now);
 
   if (latestReactionTimestamps.length > rateCountLimit) {
     const firstTimestamp = latestReactionTimestamps[0];
-    if (timestamp - firstTimestamp < rateTimeLimit) {
+    if (now - firstTimestamp < rateTimeLimit) {
       latestReactionTimestamps.pop();
-      window.log.warn('Only 20 reactions are allowed per minute');
+      window.log.warn(`Only ${rateCountLimit} reactions are allowed per minute`);
       return true;
     } else {
       latestReactionTimestamps.shift();
@@ -86,6 +86,7 @@ const sendMessageReaction = async (messageId: string, emoji: string) => {
     }
 
     if (hitRateLimit()) {
+      ToastUtils.pushRateLimitHitReactions();
       return;
     }