fix: display 0 seconds timer as off

ts/session/disappearing_messages/timerOptions.ts

@@ -36,7 +36,10 @@ const VALUES: Array<number> = [
 ];
 
 function getName(seconds = 0) {
-  if (seconds >= 0) {
+  if (seconds === 0) {
+    return window.i18n('off');
+  }
+  if (seconds > 0) {
     return formatTimeDuration(seconds * 1000);
   }
 

ts/util/i18n/formater/expirationTimer.ts

@@ -60,12 +60,12 @@ const secondsToDuration = (seconds: number): Duration => {
  * @returns '1h' for a duration of 3600s.
  */
 export const formatAbbreviatedExpireTimer = (timerSeconds: number) => {
-  // Note: we keep this function in this file even if it is not localizing anything
-  // so we have access to timeLocaleMap.en.
-
   if (timerSeconds > DURATION_SECONDS.WEEKS * 4) {
     throw new Error('formatAbbreviatedExpireTimer is not design to handle >4 weeks durations ');
   }
+  if (timerSeconds <= 0) {
+    return window.i18n('off');
+  }
 
   const duration = secondsToDuration(timerSeconds);
 
@@ -84,9 +84,6 @@ export const formatAbbreviatedExpireTimer = (timerSeconds: number) => {
  * @returns '1h' for a duration of 3600s.
  */
 export const formatAbbreviatedExpireDoubleTimer = (timerSeconds: number) => {
-  // Note: we keep this function in this file even if it is not localizing anything
-  // so we have access to timeLocaleMap.en.
-
   if (timerSeconds > DURATION_SECONDS.WEEKS * 4) {
     throw new Error(
       'formatAbbreviatedExpireDoubleTimer is not design to handle >4 weeks durations '