From 07ac6fa47b882756f2e257bbf285dae0dcdb780e Mon Sep 17 00:00:00 2001 From: yougotwill Date: Fri, 7 Mar 2025 16:10:53 +1100 Subject: [PATCH] feat: change ui label for latest channel to stable --- .github/workflows/build-binaries.yml | 1 + ts/components/dialog/debug/ReleaseChannel.tsx | 4 ++-- ts/components/dialog/debug/components.tsx | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml index 48daa8571..2ac5dd6d3 100644 --- a/.github/workflows/build-binaries.yml +++ b/.github/workflows/build-binaries.yml @@ -24,6 +24,7 @@ concurrency: env: # we want to publish on "push to master" only. When we don't want to publish, we want to upload artefacts SHOULD_PUBLISH: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }} + # TODO Are we happy with this condition? SHOULD_PUBLISH_ALPHA: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/heads/release') && contains(github.ref, '-alpha.') }} jobs: diff --git a/ts/components/dialog/debug/ReleaseChannel.tsx b/ts/components/dialog/debug/ReleaseChannel.tsx index 62e70f1f2..5ba330fdc 100644 --- a/ts/components/dialog/debug/ReleaseChannel.tsx +++ b/ts/components/dialog/debug/ReleaseChannel.tsx @@ -12,7 +12,7 @@ import { Storage } from '../../../util/storage'; const items = [ { - label: capitalize(LATEST_CHANNEL), + label: 'Stable', value: LATEST_CHANNEL, inputDataTestId: `input-releases-${LATEST_CHANNEL}` as const, labelDataTestId: `label-releases-${LATEST_CHANNEL}` as const, @@ -33,7 +33,7 @@ export const ReleaseChannel = () => { const changeReleaseChannel = (channel: ReleaseChannels) => { window.log.debug( - `WIP: [debugMenu] Setting release channel to ${channel}. It was ${Storage.get('releaseChannel') || 'not set'}` + `[debugMenu] Setting release channel to ${channel}. It was ${Storage.get('releaseChannel') || 'not set'}` ); dispatch( updateConfirmModal({ diff --git a/ts/components/dialog/debug/components.tsx b/ts/components/dialog/debug/components.tsx index 35cc694e6..df1eb29c7 100644 --- a/ts/components/dialog/debug/components.tsx +++ b/ts/components/dialog/debug/components.tsx @@ -108,7 +108,7 @@ export const DebugActions = () => { }} > - {!loadingLatestRelease ? 'Check latest release' : null} + {!loadingLatestRelease ? 'Check stable version' : null} { @@ -145,7 +145,7 @@ export const DebugActions = () => { }} > - {!loadingAlphaRelease ? 'Check alpha release' : null} + {!loadingAlphaRelease ? 'Check alpha version' : null}