Fix some corner casese with last seen indicator

* Remove increment behavior
* Dismiss when new messages arrive but the window is focused
* Update the indicator when window becomes focused.

// FREEBIE
pull/749/head
lilia 8 years ago committed by Scott Nonnenberg
parent bb468e7b01
commit 017bb56cca

@ -116,7 +116,7 @@
var onFocus = function() {
if (this.$el.css('display') !== 'none') {
this.markRead();
this.updateUnread();
}
}.bind(this);
this.window.addEventListener('focus', onFocus);
@ -324,11 +324,8 @@
this.model.messageCollection.add(message, {merge: true});
message.setToExpire();
if (this.lastSeenIndicator) {
this.lastSeenIndicator.increment(1);
}
if (!this.isHidden() && window.isFocused()) {
this.removeLastSeenIndicator();
this.markRead();
}
},

@ -13,11 +13,6 @@
this.count = options.count || 0;
},
increment: function(count) {
this.count += count;
this.render();
},
render_attributes: function() {
var unreadMessages = this.count === 1 ? i18n('unreadMessage')
: i18n('unreadMessages', [this.count]);

@ -9,10 +9,4 @@ describe('LastSeenIndicatorView', function() {
assert.equal(view.count, 10);
});
it('increments count', function() {
var view = new Whisper.LastSeenIndicatorView({count: 4});
assert.equal(view.count, 4);
view.increment(3);
assert.equal(view.count, 7);
});
});

Loading…
Cancel
Save