chore: cleanup strings usages

ts/components/basic/StyledI18nSubText.tsx

@@ -15,12 +15,6 @@ const StyledI18nSubTextContainer = styled('div')`
   padding-inline: var(--margins-lg);
 `;
 
-const StyledI18nSubMessageTextContainer = styled('div')`
-  // Overrides SASS in this one case
-  margin-top: 0;
-  margin-bottom: var(--margins-md);
-`;
-
 export const StyledI18nSubText = forwardRef<HTMLSpanElement, I18nProps<LocalizerToken>>(
   ({ className, ...props }) => {
     return (
@@ -30,13 +24,3 @@ export const StyledI18nSubText = forwardRef<HTMLSpanElement, I18nProps<Localizer
     );
   }
 );
-
-export const StyledI18nSubMessageText = forwardRef<HTMLSpanElement, I18nProps<LocalizerToken>>(
-  ({ className, ...props }) => {
-    return (
-      <StyledI18nSubMessageTextContainer className={className}>
-        <I18n {...props} />
-      </StyledI18nSubMessageTextContainer>
-    );
-  }
-);

ts/components/conversation/header/ConversationHeaderTitle.tsx

@@ -82,7 +82,7 @@ export const ConversationHeaderTitle = (props: ConversationHeaderTitleProps) =>
 
     if (isGroup && memberCount > 0 && !isKickedFromGroup) {
       const count = String(memberCount);
-      return i18n(isPublic ? 'membersActive' : 'members', { count });
+      return isPublic ? i18n('membersActive', { count }) : i18n('members', { count });
     }
 
     return null;

ts/components/dialog/OpenUrlModal.tsx

@@ -48,7 +48,7 @@ export function OpenUrlModal(props: OpenUrlModalState) {
     >
       <div className="session-modal__centered">
         <StyledScrollDescriptionContainer>
-          <StyledI18nSubText asTag="span" token="urlOpenDescription" args={{ url }} />
+          <StyledI18nSubText token="urlOpenDescription" asTag="span" args={{ url }} />
         </StyledScrollDescriptionContainer>
       </div>
       <SpacerMD />

ts/components/dialog/StyledSubText.tsx

@@ -1,24 +0,0 @@
-import styled from 'styled-components';
-
-/**
- * @deprecated Use {@link StyledI18nSubText} instead.
- */
-export const StyledSubText = styled('span')<{ textLength: number }>`
-  font-size: var(--font-size-md);
-  line-height: 1.5;
-  margin-bottom: var(--margins-lg);
-
-  max-width: ${props =>
-    props.textLength > 90
-      ? '60ch'
-      : '33ch'}; // this is ugly, but we want the dialog description to have multiple lines when a short text is displayed
-`;
-
-/**
- * @deprecated Use {@link StyledI18nSubMessageText} instead.
- */
-export const StyledSubMessageText = styled('span')`
-  // Overrides SASS in this one case
-  margin-top: 0;
-  margin-bottom: var(--margins-md);
-`;