From acb4f1d4661a098499483ef9fce266032df7ccd9 Mon Sep 17 00:00:00 2001
From: jubb <hjubb@users.noreply.github.com>
Date: Mon, 6 Dec 2021 09:35:33 +1100
Subject: [PATCH] refactor: change the call time to update every second

---
 .../thoughtcrime/securesms/calls/WebRtcCallActivity.kt    | 8 +++++---
 app/src/main/res/layout/activity_webrtc.xml               | 5 +++--
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/calls/WebRtcCallActivity.kt b/app/src/main/java/org/thoughtcrime/securesms/calls/WebRtcCallActivity.kt
index d1d446f1d9..80acbb6ef1 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/calls/WebRtcCallActivity.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/calls/WebRtcCallActivity.kt
@@ -23,6 +23,7 @@ import kotlinx.coroutines.flow.collect
 import kotlinx.coroutines.isActive
 import kotlinx.coroutines.launch
 import network.loki.messenger.R
+import org.apache.commons.lang3.time.DurationFormatUtils
 import org.session.libsession.avatars.ProfileContactPhoto
 import org.session.libsession.messaging.contacts.Contact
 import org.thoughtcrime.securesms.PassphraseRequiredActionBarActivity
@@ -35,6 +36,7 @@ import org.thoughtcrime.securesms.webrtc.AudioManagerCommand
 import org.thoughtcrime.securesms.webrtc.CallViewModel
 import org.thoughtcrime.securesms.webrtc.CallViewModel.State.*
 import org.thoughtcrime.securesms.webrtc.audio.SignalAudioManager.AudioDevice.*
+import java.text.SimpleDateFormat
 import java.time.Duration
 import java.util.*
 
@@ -48,7 +50,7 @@ class WebRtcCallActivity: PassphraseRequiredActionBarActivity() {
 
         const val BUSY_SIGNAL_DELAY_FINISH = 5500L
 
-        val CALL_DURATION_FORMAT = 
+        private const val CALL_DURATION_FORMAT = "HH:mm:ss"
     }
 
     private val viewModel by viewModels<CallViewModel>()
@@ -198,10 +200,10 @@ class WebRtcCallActivity: PassphraseRequiredActionBarActivity() {
                         callTime.isVisible = false
                     } else {
                         callTime.isVisible = true
-                        callTime.text = Duration.Duration.ofMillis(startTime)
+                        callTime.text = DurationFormatUtils.formatDuration(System.currentTimeMillis() - startTime, CALL_DURATION_FORMAT)
                     }
 
-                    delay(5_000) // update the call duration less frequently
+                    delay(1_000)
                 }
             }
 
diff --git a/app/src/main/res/layout/activity_webrtc.xml b/app/src/main/res/layout/activity_webrtc.xml
index 8197415205..2b004ead41 100644
--- a/app/src/main/res/layout/activity_webrtc.xml
+++ b/app/src/main/res/layout/activity_webrtc.xml
@@ -43,13 +43,14 @@
         tools:visibility="visible" />
 
     <TextView
-        android:textSize="@dimen/text_size"
+        android:id="@+id/callTime"
+        android:textSize="@dimen/medium_font_size"
         android:textColor="@color/text"
         tools:text="00:05:20"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintBottom_toTopOf="@+id/controlGroupBarrier"
-        android:layout_marginBottom="@dimen/medium_spacing"
+        android:layout_marginBottom="@dimen/very_large_spacing"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"/>