From 9f414aa52c9238efd3cfd70879da859097da9393 Mon Sep 17 00:00:00 2001 From: ThomasSession Date: Fri, 28 Feb 2025 00:00:54 +0200 Subject: [PATCH] SES-2113 - Never display a username that matches that user's id. Truncate instead (#992) --- .../org/thoughtcrime/securesms/util/UsernameUtilsImpl.kt | 5 ++++- app/src/main/res/layout/view_conversation_action_bar.xml | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/UsernameUtilsImpl.kt b/app/src/main/java/org/thoughtcrime/securesms/util/UsernameUtilsImpl.kt index 203525ba66..999682f098 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/UsernameUtilsImpl.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/util/UsernameUtilsImpl.kt @@ -46,6 +46,9 @@ class UsernameUtilsImpl( configFactory.withGroupConfigs(groupId) { it.groupMembers.getOrNull(accountID)?.name } } else null - return userName ?: truncateIdForDisplay(accountID) + // if the username is actually set to the user's accountId, truncate it + val validatedUsername = if(userName == accountID) truncateIdForDisplay(accountID) else userName + + return validatedUsername ?: truncateIdForDisplay(accountID) } } \ No newline at end of file diff --git a/app/src/main/res/layout/view_conversation_action_bar.xml b/app/src/main/res/layout/view_conversation_action_bar.xml index bc406d0e70..7ea15b4005 100644 --- a/app/src/main/res/layout/view_conversation_action_bar.xml +++ b/app/src/main/res/layout/view_conversation_action_bar.xml @@ -17,8 +17,11 @@