From 8e1ca752d957e1a24617abde81f291091884973c Mon Sep 17 00:00:00 2001
From: ThomasSession <thomas.r@getsession.org>
Date: Wed, 5 Mar 2025 16:34:21 +1100
Subject: [PATCH] Fixing logs sharing crashing

---
 .../securesms/logging/LogFile.java            | 34 +++++++++++++------
 1 file changed, 23 insertions(+), 11 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/logging/LogFile.java b/app/src/main/java/org/thoughtcrime/securesms/logging/LogFile.java
index cfe6cc3809..2072e783b2 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/logging/LogFile.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/logging/LogFile.java
@@ -129,25 +129,37 @@ class LogFile {
 
     String readEntry() throws IOException {
       try {
+        // Read the IV and length
         Util.readFully(inputStream, ivBuffer);
         Util.readFully(inputStream, intBuffer);
+      } catch (EOFException e) {
+        // End of file reached before a full header could be read.
+        return null;
+      }
 
-        int    length     = Conversions.byteArrayToInt(intBuffer);
-        byte[] ciphertext = ciphertextBuffer.get(length);
+      int length = Conversions.byteArrayToInt(intBuffer);
+      byte[] ciphertext = ciphertextBuffer.get(length);
 
+      try {
         Util.readFully(inputStream, ciphertext, length);
+      } catch (EOFException e) {
+        // Incomplete ciphertext – likely due to a partially written record.
+        return null;
+      }
 
-        try {
-          synchronized (CIPHER_LOCK) {
-            cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec(secret, "AES"), new IvParameterSpec(ivBuffer));
-            byte[] plaintext = cipher.doFinal(ciphertext, 0, length);
-            return new String(plaintext);
-          }
-        } catch (InvalidKeyException | InvalidAlgorithmParameterException | IllegalBlockSizeException | BadPaddingException e) {
-          throw new AssertionError(e);
+      try {
+        synchronized (CIPHER_LOCK) {
+          cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec(secret, "AES"), new IvParameterSpec(ivBuffer));
+          byte[] plaintext = cipher.doFinal(ciphertext, 0, length);
+          return new String(plaintext);
         }
-      } catch (EOFException e) {
+      } catch (BadPaddingException e) {
+        // Bad padding likely indicates a corrupted or incomplete entry.
+        // Instead of throwing an error, treat this as the end of the log.
         return null;
+      } catch (InvalidKeyException | InvalidAlgorithmParameterException
+               | IllegalBlockSizeException e) {
+        throw new AssertionError(e);
       }
     }
   }