From 34f2def12228e0ba295b2c363cb2ccac86553696 Mon Sep 17 00:00:00 2001 From: ryanzhao Date: Mon, 29 Jun 2020 14:15:20 +1000 Subject: [PATCH 1/2] Drop banned proxy to fix link previews --- .../securesms/linkpreview/LinkPreviewRepository.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java b/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java index 1e9fff7f65..ef2923d1a8 100644 --- a/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java +++ b/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java @@ -63,7 +63,10 @@ public class LinkPreviewRepository implements InjectableType { public LinkPreviewRepository(@NonNull Context context) { this.client = new OkHttpClient.Builder() - .proxySelector(new ContentProxySelector()) + //It seems like Signal's proxy has been banned by Youtube. + //Just comment this out to fix link previews. + //We will move this to onion routing in the future + //.proxySelector(new ContentProxySelector()) .addNetworkInterceptor(new ContentProxySafetyInterceptor()) .cache(null) .build(); From a4c5ec823d2962294412b7ebfa5ced789c694681 Mon Sep 17 00:00:00 2001 From: nielsandriesse Date: Wed, 8 Jul 2020 10:51:32 +1000 Subject: [PATCH 2/2] Reword comment --- .../securesms/linkpreview/LinkPreviewRepository.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java b/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java index ef2923d1a8..c213963d75 100644 --- a/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java +++ b/src/org/thoughtcrime/securesms/linkpreview/LinkPreviewRepository.java @@ -21,7 +21,6 @@ import org.thoughtcrime.securesms.mms.GlideApp; import org.thoughtcrime.securesms.net.CallRequestController; import org.thoughtcrime.securesms.net.CompositeRequestController; import org.thoughtcrime.securesms.net.ContentProxySafetyInterceptor; -import org.thoughtcrime.securesms.net.ContentProxySelector; import org.thoughtcrime.securesms.net.RequestController; import org.thoughtcrime.securesms.providers.BlobProvider; import org.thoughtcrime.securesms.stickers.StickerRemoteUri; @@ -63,10 +62,7 @@ public class LinkPreviewRepository implements InjectableType { public LinkPreviewRepository(@NonNull Context context) { this.client = new OkHttpClient.Builder() - //It seems like Signal's proxy has been banned by Youtube. - //Just comment this out to fix link previews. - //We will move this to onion routing in the future - //.proxySelector(new ContentProxySelector()) + // .proxySelector(new ContentProxySelector()) // Loki: Signal's proxy appears to have been banned by YouTube .addNetworkInterceptor(new ContentProxySafetyInterceptor()) .cache(null) .build();