The function get_user_list returns a list of users on stdout, so
obviously it can't use stdout to also display messages. Use stderr
instead.
Note that we could also silently skip if we find a directory in /home
that is not a user. Does it happen in practice?
The vboxsf group is created by the postinst script of the package
virtualbox-guest-utils. The kali user needs to be part of this group
in order to access VirtualBox's shared folders.
This change does just that. It's effective for all the Live images
(where VirtualBox guest additions are installed unconditionnally),
and for the systems installed by the Installer image where VirtualBox
was detected (and therefore VirtualBox guest additions were installed).
Ref: <https://bugs.kali.org/view.php?id=7643>
Up to now, it was fine to use a command such as:
usermod -a -G group1,group2,... kali
However a limitation is that all the groups that are given to the option
-G must exist. If that's not the case, usermod fails (return code: 6)
without doing anything, and the user is not added to any group.
So with this commit, we prepare the code to support optional groups,
that might or might not exist. If ever a group does not exist, it's
skipped silently.
Changes:
- order groups alphabetically
- use the same comment "Ensure those groups exist" consistently in the 2
scripts, and also drop the comment regarding a "generically named"
function.
- adds "|| true" to the usermod command in kali-user-setup (only for
consistency, the script is not run with "set -e" anyway).
After those changes, the two functions "configure_usergroups()" are very
similar, and it's very easy to spot the differences between both.
This was introduced in 5989ec37de, and
probably that was not the intention.
Adding root to groups doesn't break anything, but I don't think it makes
any sense either.
This reverts commit d1ad9e1ea2.
The empty directory `local_packages` was there for a reason.
`simple-cdd` gives a warning when this directory doesn't exist:
WARNING local package source /home/kali/live-build-config/simple-cdd/local_packages is neither a file nor a directory
So re-instate this empty dir to keep the logs clean.
I assume that `variant-minimal` was also there for a good reason.
This reverts commit 50a06be454.
This commit was needed only in order to include the package in the
2021.3a Kali images. Not needed anymore, and not needed to build 2021.4.
This reverts commit aaf1a294ee.
The arm64 version of openvm-tools-desktop is still hiding in kali-experimental
so adding it in now would break the ISO builds.
Now that the open-vm-tools package supports arm64 and VMWare fusion is available for the M1 Macbooks, lets make sure that open-vm-tools-desktop is also available for arm64.
This is a temporary fix to be able to build fixed netinst
images for 2021.3 but in the long term, we need to move the
firmware dependencies to a dedicated package to avoid that kind
of issue.
Relates to #36.
« XRDP is what enables Hyper-V's Enhanced session mode. It also enables
Hyper-V to automatically connect via RDP, which is what fixes input
lag/allows simpler window resizing/shared clipboard. »
Big thanks to @jetbennett for the detailed report. For more context:
https://gitlab.com/kalilinux/build-scripts/live-build-config/-/issues/32#note_645975695Fixes: #33
Daniel Ruiz de Alegría
Arnaud Rebillout
Sophie Brun
Raphaël Hertzog
Steev Klimaszewski
g0t mi1k